Add typing annotations and modernize codebase; remove .pyi stubs#193
Merged
Add typing annotations and modernize codebase; remove .pyi stubs#193
Conversation
Owner
Author
|
Codex was having a hard time getting the request right, I manually went through and did the final pass to fix the Any types it added and get to a green dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tyrules and small runtime fixes to make static checks and runtime behavior more robust.Description
from __future__ import annotationsand inlined type hints (parameters and return types) across many modules, including__main__.py,constants.py,demo.py,global_state.py, and multipleutilsmodules..pyistub files and consolidated typing into the implementation files, and added# type: ignore[attr-defined]where necessary in__main__.pyto silence false positives.pyproject.tomlto include a new[tool.ty.rules]section to ignore a broad set of type-check rules during gradual typing adoption.parsertoconfig_parserin__main__.py, improvingadd_line_numbersandhighlighthelpers inutil_str.py, adding runtimeassertchecks, and refining async utilities and TempDir typings.Testing
pytestand all tests completed successfully.python -m xdoctestsmoke runs and confirmed the--version/--version-infoflows exit with expected codes.Codex Task