Feature/issue 145 share actions resend email#189
Open
perezjnr wants to merge 7 commits intoErugoOSS:mainfrom
Open
Feature/issue 145 share actions resend email#189perezjnr wants to merge 7 commits intoErugoOSS:mainfrom
perezjnr wants to merge 7 commits intoErugoOSS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recipient management for shares (initial implementation)
This only details with part one of the issue, as it's best to split features into different PRs
This change introduces recipient management for file shares, allowing sharers to view, add, edit, remove, and resend share invitations after a share has been created.
Recipient email addresses are stored only for the lifetime of the share and are automatically removed when a share expires, keeping data retention minimal. Recipient names are optional and, when provided, are used to personalise email greetings. Email addresses remain the unique identifier per share to prevent duplicates.
The functionality is available from both My Shares and All Shares via a shared recipients modal, avoiding duplication of logic and keeping behaviour consistent across views. Existing authorisation checks are respected so that only users who can manage a share may modify its recipients.
This implementation focuses on core functionality and correctness. There will be further improvements as part of this issue, including refinement of the user experience, validation and error handling, and alignment with Vue best practices.