[cpp] fixed Memory access out of bounds error caused by unhandled null return of RegionAttachment when loading default skin#3037
Open
driftboat wants to merge 1 commit intoEsotericSoftware:3.8from
Open
Conversation
…d, to prevent subsequent reading from causing a Memory access out of bounds error
driftboat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the texture packer is set to ignore blank images and exports a binary animation with empty sprites,
during the loading of the default skin in the skeleton file, the RegionAttachment returns null,
but there is no error handling or early return,
so the parsing continues, leading to misalignment and corruption in subsequent reads.