Skip to content

Commit 5927593

Browse files
authored
Update loggings to make sure builders are run correctly (#1870)
Closes #<ISSUE_NUMBER> <!-- These comments should help create a useful PR message, please delete any remaining comments before opening the PR. --> <!-- If there is no issue number make sure to describe clearly *why* this PR is necessary. --> <!-- Mention open questions, remaining TODOs, if any --> ### This PR: * Reapply changes in #1867, which was reverted by #1869. ### This PR does not: <!-- Describe what is out of scope for this PR, if applicable. Leave this section blank if it's not applicable --> <!-- This section helps avoid the reviewer having to needlessly point out missing parts --> <!-- * Implement feature 3 because that feature is blocked by Issue 4 --> <!-- * Implement xyz because that is tracked in issue #123. --> <!-- * Address xzy for which I opened issue #456 --> ### Key places to review: <!-- Describe key places for reviewers to pay close attention to --> <!-- * file.rs, `add_integers` function --> <!-- Or directly comment on those files/lines to make it easier for the reviewers --> <!-- ### How to test this PR: --> <!-- Optional, uncomment the above line if this is relevant to your PR --> <!-- If your PR is fully tested through CI there is no need to add this section --> <!-- * E.g. `just test` --> <!-- ### Things tested --> <!-- Anything that was manually tested (that is not tested in CI). --> <!-- E.g. building/running of docker containers. Changes to docker demo, ... --> <!-- Especially mention anything untested, with reasoning and link an issue to resolve this. --> <!-- Complete the following items before creating this PR --> <!-- [ ] Issue linked or PR description mentions why this change is necessary. --> <!-- [ ] PR description is clear enough for reviewers. --> <!-- [ ] Documentation for changes (additions) has been updated (added). --> <!-- [ ] If this is a draft it is marked as "draft". --> <!-- To make changes to this template edit https://github.com/EspressoSystems/.github/blob/main/PULL_REQUEST_TEMPLATE.md -->
2 parents 4030ffd + 4755d43 commit 5927593

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

marketplace-builder/src/builder.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -206,26 +206,29 @@ impl BuilderConfig {
206206
let res =
207207
run_non_permissioned_standalone_builder_service(hooks, senders, events_url)
208208
.await;
209-
tracing::error!(?res, "builder service exited");
209+
tracing::error!(?res, "Reserve builder service exited");
210210
if res.is_err() {
211-
panic!("Builder should restart.");
211+
panic!("Reserve builder should restart.");
212212
}
213213
});
214+
215+
tracing::info!("Reserve builder init finished");
214216
} else {
215217
let hooks = hooks::EspressoFallbackHooks { solver_api_url };
216218

217219
async_spawn(async move {
218220
let res =
219221
run_non_permissioned_standalone_builder_service(hooks, senders, events_url)
220222
.await;
221-
tracing::error!(?res, "builder service exited");
223+
tracing::error!(?res, "Fallback builder service exited");
222224
if res.is_err() {
223-
panic!("Builder should restart.");
225+
panic!("Fallback builder should restart.");
224226
}
225227
});
228+
229+
tracing::info!("Fallback builder init finished");
226230
}
227231

228-
tracing::info!("Builder init finished");
229232
Ok(Self {
230233
global_state,
231234
hotshot_events_api_url,

0 commit comments

Comments
 (0)