Skip to content

fix: handle variable-size buffer for U256 #3570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle variable-size buffer for U256 #3570

wants to merge 1 commit into from

Conversation

brawncode
Copy link

This PR:

U256::from_le_slice assumed 32-byte input, but serialize_uncompressed can give more or less.
now we properly handle the buffer so conversion won’t break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

@imabdulbasit imabdulbasit Awaiting requested review from imabdulbasit imabdulbasit is a code owner

@ss-es ss-es Awaiting requested review from ss-es ss-es is a code owner

@pls148 pls148 Awaiting requested review from pls148 pls148 is a code owner

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

@rob-maron rob-maron Awaiting requested review from rob-maron rob-maron is a code owner

@lukaszrzasik lukaszrzasik Awaiting requested review from lukaszrzasik lukaszrzasik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brawncode