chore(persistence): make vid_share2 migration idempotent with ON CONFLICT #3584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fibonacci747
requested review from
sveitser,
jbearer,
imabdulbasit,
ss-es,
pls148,
bfish713,
rob-maron and
lukaszrzasik
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing ON CONFLICT DO NOTHING to INSERT into vid_share2 in migrate_vid_shares. This aligns the function with other batch migrations (anchor_leaf, da_proposal, quorum_proposals, quorum_certificate), ensuring idempotency on batch boundaries and safe restarts. Without this, re-running a partially completed batch or resuming from an offset would attempt to re-insert rows with the same PRIMARY KEY(view), causing unique constraint violations and breaking the migration.