chore: fix some annoying Bash quirks #3642
Open
+12
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
--account-index
check now properly handles empty vs number, older Bash hated the old version.if [ "$docker" = true ]; then
) so it doesn’t try to run “true” as a command.cmd
is an array.command -v cast
check so the script won’t crash if cast isn’t installed.$("${cmd[@]}" ...)
to handle spaces properly.This PR does not:
Key places to review:
cmd
is used to run commands