Switch from per block to per epoch reward distribution ( V6 Upgrade) #3879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
force-pushed
the
ab/per-epoch-reward-distribution
branch
from
cdbcce2 to
97a2584
Compare
imabdulbasit
force-pushed
the
ab/per-epoch-reward-distribution
branch
from
9c7021e to
74d7737
Compare
imabdulbasit
changed the title
* checkpoint * reconstruct reward merkle tree
imabdulbasit
force-pushed
the
ab/per-epoch-reward-distribution
branch
from
bdd2790 to
fb10f82
Compare
bfish713
reviewed
Jan 28, 2026
types/src/v0/impls/header.rs
Outdated
| reward_calculator.spawn_background_task( | ||
| prev_epoch, | ||
| epoch_height, | ||
| validated_state.reward_merkle_tree_v2.clone(), |
Contributor
There was a problem hiding this comment.
Do we know for sure this is the correct merkle tree to pass in here, I feel it could be arbitrarily old. Maybe we can check the header.reward_merkle_tree_root == validated_state.reward_merkle_tree_v2.root and if false just pass in the empty tree with the root from the prev_epoch_header
* use new merkle tree if our root doesn't match the header * get full tree from correct header * make sure we have the full randomized stake table for the epoch * order the validators before indexing * bail if reward root doesn't equal header --------- Co-authored-by: imabdulbasit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.