Skip to content

Conversation

@shenkeyao
Copy link
Member


d := NewDevnet(ctx, t)
require.NoError(t, d.Up())
require.NoError(t, d.Up(false))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you introduce a couple of constants like?
TEE:= true
NON_TEE:=false.

@philippecamacho
Copy link
Collaborator

Is a real TEE run in this test, like in espresso-enclave.yml?

Copy link
Collaborator

@dailinsubjam dailinsubjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A relevant PR: https://github.com/EspressoSystems/optimism-espresso-integration/pull/215/files
Maybe some env settings there can be re-used here.

@shenkeyao
Copy link
Member Author

shenkeyao commented Nov 14, 2025

Is a real TEE run in this test, like in espresso-enclave.yml?

@philippecamacho It's supposed to, but I just checked the CI and found it's outputting op-batcher logs rather than op-batcher-tee. It's probably due to not passing the TEE command correctly--will add the TEE and non-TEE consts as you suggested and investigate this.

Update: Found the extra line that caused the issue. Fixed!

@shenkeyao
Copy link
Member Author

A relevant PR: https://github.com/EspressoSystems/optimism-espresso-integration/pull/215/files Maybe some env settings there can be re-used here.

@dailinsubjam I didn't find env settings in that PR that could be reused here. 🤔 Is there anything specific that you think might be helpful?

@shenkeyao
Copy link
Member Author

shenkeyao commented Nov 14, 2025

A relevant PR: https://github.com/EspressoSystems/optimism-espresso-integration/pull/215/files Maybe some env settings there can be re-used here.

@dailinsubjam I didn't find env settings in that PR that could be reused here. 🤔 Is there anything specific that you think might be helpful?

Oh by "env settings" do you mean the profile in that PR? I think we can have a type named profile, and let it be either TEE or non-TEE (default), but is there anything else besides this struct/const setting that you think I should add? The other settings in that PR seem irrelevant to this task.

Update: I added a ComposeProfile type to improve the interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants