-
Notifications
You must be signed in to change notification settings - Fork 0
Add devnet smoke test with TEE #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: celo-integration-rebase-14.1
Are you sure you want to change the base?
Conversation
|
|
||
| d := NewDevnet(ctx, t) | ||
| require.NoError(t, d.Up()) | ||
| require.NoError(t, d.Up(false)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you introduce a couple of constants like?
TEE:= true
NON_TEE:=false.
|
Is a real TEE run in this test, like in |
dailinsubjam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A relevant PR: https://github.com/EspressoSystems/optimism-espresso-integration/pull/215/files
Maybe some env settings there can be re-used here.
@philippecamacho It's supposed to, but I just checked the CI and found it's outputting Update: Found the extra line that caused the issue. Fixed! |
@dailinsubjam I didn't find env settings in that PR that could be reused here. 🤔 Is there anything specific that you think might be helpful? |
Oh by "env settings" do you mean the Update: I added a |
Closes https://app.asana.com/1/1208976916964769/project/1209392461754458/task/1211430091119450?focus=true.
This PR: