Remove run_dkg_handover_decryption_phase_e2e.
#543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is redundant since [PR #502][1] was merged and is often failing on CI. The reason for its failure is a race condition: sometimes not all nodes finish the resharing because of all the DKG requests they send, less than t + 1 are answered because peers are themselves in an incomplete DKG state or they are not in a running state. In any case they are not replying. The test is then ultimately hanging and timing out because it attempts to subsequently collect the inclusion list from all decrypters and some can not provideit. The test would need to be fixed by allowing enough time for the decrypters of committee 1 to have their local DKG state ready before the members of committee 2 send their DKG requests. For production it is assumed that between scheduling the next committee and activating it, sufficient time is given. Rather than fixing the test this PR removes it because -- as mentioned above -- it is redundant with another test. [1]: #502
akonring
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is redundant since PR #502 was merged and is often failing on CI. The reason for its failure is a race condition: sometimes not all nodes finish the resharing because of all the DKG requests they send, less than t + 1 are answered because peers are themselves in an incomplete DKG state or they are not in a running state. In any case they are not replying. The test is then ultimately hanging and timing out because it attempts to subsequently collect the inclusion list from all decrypters and some can not provide it.
The test would need to be fixed by allowing enough time for the decrypters of committee 1 to have their local DKG state ready before the members of committee 2 send their DKG requests. For production it is assumed that between scheduling the next committee and activating it, sufficient time is given.
Rather than fixing the test this PR removes it because -- as mentioned above -- it is redundant with another test.
Log excerpt from a failed test run
Node
hcUWjmK8pTz5AY39CDh1gVnVbaF4nNuEf2dQ5SWXZQyhreceives only 1 DKG responseThe committee consists of 5 members, so at least 2 responses are required, however every other node is either not in a running state or has an unfinished local DKG state.
CC: @akonring, @alxiong