<Description> : Adding NSAttributed string data extension.#379
Open
<Description> : Adding NSAttributed string data extension.#379
Conversation
Khalian
force-pushed
the
dataextensions
branch
from
c3f6ef0 to
0b97e2a
Compare
lfarah
reviewed
Feb 13, 2017
Sources/DataExtensions.swift
Outdated
| public var attributedString: NSAttributedString? { | ||
| do { | ||
| return try NSAttributedString(data: self, options:[NSDocumentTypeDocumentAttribute:NSHTMLTextDocumentType, NSCharacterEncodingDocumentAttribute: String.Encoding.utf8.rawValue], documentAttributes: nil) | ||
| } catch let error as NSError { |
Collaborator
There was a problem hiding this comment.
@Khalian Do we need to use NSError or we can use Swift's Error?
Collaborator
Author
There was a problem hiding this comment.
Good callout. I fixed that.
Generated by 🚫 Danger |
Khalian
force-pushed
the
dataextensions
branch
from
0b97e2a to
849232a
Compare
Collaborator
Author
|
UIColor Tests are blowing up for some reason. |
lfarah
approved these changes
Mar 10, 2017
<Type> : feature/test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
: feature/test
Checklist