Erick/cherry pick pr 1044 1048 1049 #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gunther Heppner <[email protected]>
sorenoid
approved these changes
Jan 7, 2026
Collaborator
|
@eri9000 - I will approve as soon as the remaining commit is picked into this PR. |
Collaborator
|
Please also run a vTest. |
eri9000
changed the title
gunt0001
reviewed
Jan 8, 2026
...uthentication/src/main/java/com/arcgismaps/toolkit/authentication/OAuthUserSignInActivity.kt
Show resolved
Hide resolved
...ication/src/androidTest/java/com/arcgismaps/toolkit/authentication/OAuthUserLauncherTests.kt
Show resolved
Hide resolved
gunt0001
approved these changes
Jan 8, 2026
...ication/src/androidTest/java/com/arcgismaps/toolkit/authentication/OAuthUserLauncherTests.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #https://devtopia.esri.com/runtime/kotlin/issues/6659
Summary of changes:
Cherry Picks PRs Erick/fail gracefully no customtabs support #1044 Fail gracefully when there's no custom-tab support for IAP SignIn and SignOut #1048 removes iapSignInNoCustomTabs test #1049
Note: as part of this PR i deleted
OAuthUserLauncherTest. These test do not not exist inv.nextand were removed after we branched off to thelts.nextbranch. See PR where we remove these test: Removes deprecated API #979Additionally, there was a declaration conflict with
RESULT_CODE_SUCCESSandRESULT_CODE_CANCELEDso i've renamed them fromOAuthUserSignInActivity. These class isn't used anymore.Pre-merge Checklist