- 
                Notifications
    
You must be signed in to change notification settings  - Fork 205
 
Update screenshots - maps, scene and layers category #1898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v.next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all I want to say that the UI on these samples looks a lot better having the unified styling. They look really good, great job!
There is a decent chunk(30% is my guess) of images that contain the attribution bar and a licensing watermark. I prefer these not be in the screenshot since they are not relevant to the sample but I don't remember if there is a firm stance on this with samples or not.
There was one sample that I noticed the scale was different which resulted in a image that was quite different than the original, unsure if that was intentional or not. There was one where the alignment of a column was slightly off and the rest I believe were just comments on the above about licensing and attribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original image didn't have the attribution bar or licensing watermark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get it consistent we need a way to hide those if needed just to capture screen shots. At least the licensing watermark because it is positioned in any of the 4 corners at random.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a thought but i wonder how this scales to a mobile device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


Description
Changes also include minor qml fixes for the export tiles and export vector tiles samples.
Added spacing to group layers sample qml items.
Type of change
Platforms tested on:
Checklist