Skip to content

Conversation

@min14751
Copy link

@min14751 min14751 commented Oct 31, 2025

Description

Changes also include minor qml fixes for the export tiles and export vector tiles samples.
Added spacing to group layers sample qml items.

Type of change

  • Bug fix
  • New sample implementation
  • Sample viewer enhancement
  • Other enhancement

Platforms tested on:

  • Windows
  • Android
  • Linux
  • macOS
  • iOS

Checklist

  • Runs and compiles on all active platforms as a standalone sample
  • Runs and compiles in the sample viewer(s)
  • Branch is up to date with the latest main/v.next
  • All merge conflicts have been resolved
  • Self-review of changes
  • There are no warnings related to changes
  • No unrelated changes have been made to any other code or project files
  • Code is commented with correct formatting (CTRL+i)
  • All variable and method names are camel case
  • There is no leftover commented code
  • Screenshots are correct size and display in description tab (500px by 500px, platform agnostic)
  • If adding a new sample, it is added to the sample viewer
  • Cherry-picked to Main branch (if applicable)

@min14751 min14751 requested review from a team, GuillaumeBelzPro, bri12415 and jared-2016 and removed request for a team and GuillaumeBelzPro October 31, 2025 23:07
Copy link
Collaborator

@jared-2016 jared-2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all I want to say that the UI on these samples looks a lot better having the unified styling. They look really good, great job!

There is a decent chunk(30% is my guess) of images that contain the attribution bar and a licensing watermark. I prefer these not be in the screenshot since they are not relevant to the sample but I don't remember if there is a firm stance on this with samples or not.

There was one sample that I noticed the scale was different which resulted in a image that was quite different than the original, unsure if that was intentional or not. There was one where the alignment of a column was slightly off and the rest I believe were just comments on the above about licensing and attribution.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original image didn't have the attribution bar or licensing watermark.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get it consistent we need a way to hide those if needed just to capture screen shots. At least the licensing watermark because it is positioned in any of the 4 corners at random.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a thought but i wonder how this scales to a mobile device.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-11-03 at 10 55 40 AM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong sample but same layout
Screenshot 2025-11-03 at 4 17 43 PM

@min14751 min14751 requested a review from jared-2016 November 3, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants