Re-templatize a Deployed Solution

[previnWong]

Hey guys,

This is more a review right now than a merge. Can you see if I forgot any gotchas in this work. Idea is that you can re-templatize a solution you deployed. And below is my assumptions

0. I check if the item is Solution Item and if it has been Deployed
1. I read the item ids from the Solution Item
2. I check if those items still exists and only keep those.
3. I check for new things in the folder that were not in the Solution item and add them to the item id list.
4. then call create Solution on the item id list.

Also, in the Create JS Demo, I removed (hide) the destination credentials. It causes issues when destination is not the same as source for some items. Since Creation App only has one login, kept it the same way.

https://devtopia.esri.com/WebGIS/solution-deployment-apps/issues/268

[MikeTschudi]

• Perhaps it would be better to create a new demo, e.g., "recreateSolution" rather than modify "createSolution"?
• Is the speed for checking for existing items acceptable? For speed, you could push the promise for each item or group fetch into an array, and then use Promise.allSettled() to wait for all of the results.

[jmhauck]

The general approach sounds good to me.

[previnWong]

Ok, let me make a different demo for re-deployed solutions.

I'll try adding a promises.all to the logic.

[MikeTschudi]

Promise.allSettled is what you'd want here, not Promise.all: the latter "rejects when any of the input's promises rejects", whereas the former waits until all promises have been resolved, whether successfully or with a failure. One then can go through the list of results filtering out the failures by keeping only ones with a status of "fulfilled".

For example,

const itemFetchPromises = solutionData.templates.map((template: any) => {
  return common.getItemBase(template.itemId as string, userSession);
});
const itemFetches = await Promise.allSettled(itemFetchPromises);
const items = itemFetches
  .filter((item: any) => item.status === "fulfilled")
  .map((item: any) => item.value);

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d3142be) to head (e42423b).
Report is 14 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop     #1520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          153       153           
  Lines         8301      8347   +46     
  Branches      1903      1920   +17     
=========================================
+ Hits          8301      8347   +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[previnWong]

@MikeTschudi @jmhauck can you guys review this for merging this time. Added a new demo so there's alot of files around that making it seem a bigger PR than it is.

[MikeTschudi]

Would you please add function documentation?

[previnWong]

right! thanks for the reminder.

[previnWong]

added function doc.