stotymap feature layer with polygon support#60
Open
sharif26 wants to merge 4 commits intoEsri:masterfrom
Open
Conversation
coded added to handle feature layer with polygon, getCentroid() function is used in case of polygon type.
code changed to support polygon shape.
added code to support polygon shape
|
Hi @sharif26, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
Story Map is a great tool for story telling with GIS data.
Now we got a feature layer with polygon shape.
But unfortunately it only works with point data and I found that there are some requests for polygon.
So I tried to change the code so that it also works with polygon feature layer.
I just put the centroid of the polygon wherever necessary and also change few condition to support polygon.
Please review my fork & pull request.
It may not be fully complete, but it works with our current polygon feature and webmap.
So I think it can be a good start.
Have a great long weekend.
Thanks in advance
Sharif Ahmed
9/2/2016