Inspector: Replace click.svg with png #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elementa's SVG renderer only works on legacy OpenGL, so this button is invisible on modern versions. This commit fixes that by baking the svg to png and using that instead. Converted using ImageMagick (`convert -density 1200 -resize 48x48 -background none ../../svg/click.svg click.png`) after changing the stroke color to `white`.
Sychic
reviewed
Nov 20, 2024
Member
Sychic
left a comment
Sychic
left a comment
There was a problem hiding this comment.
Should the svg be removed if it is no longer used? Or is it being retained for reference purposes?
Contributor
Author
I kept it in case some third-party mod uses it. |
DJtheRedstoner
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elementa's SVG renderer only works on legacy OpenGL, so this button is invisible on modern versions.
This commit fixes that by baking the svg to png and using that instead.
Converted using ImageMagick (
convert -density 1200 -resize 48x48 -background none ../../svg/click.svg click.png) after changing the stroke color towhite.