Add config option for logging console/RCON commands #6337
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
requested changes
Oct 25, 2025
Comment on lines
-750
to
+752
| LOGGER.log(Level.INFO, cSender.getName()+ " issued server command: /" + commandLabel + " " + EssentialsCommand.getFinalArg(args, 0)); | ||
| if (getSettings().logConsoleRconCommands()) { | ||
| LOGGER.log(Level.INFO, cSender.getName()+ " issued server command: /" + commandLabel + " " + EssentialsCommand.getFinalArg(args, 0)); | ||
| } |
There was a problem hiding this comment.
i think we should be checking if cSender is an instance of RemoteConsoleCommandSender instead? won't this catch console messages too?
There was a problem hiding this comment.
that's intended behavior, i meant for this to catch both console and RCON commands. i can change this to use separate config options if you'd like
There was a problem hiding this comment.
hmm okay, i think we should rename the config option to log-console-command over specifically rcon then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
Closes #6336.
Details
This adds a config option that allows disabling the logging of console and RCON commands.
Environments tested:
OS: Arch Linux
Java version: openjdk 21.0.8 2025-07-15
Demonstration:
Without these changes, with the config option not set:
With these changes, with the config option set to false:
