Skip to content

Potential priority fix #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Potential priority fix #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ugin/src/main/java/com/eternalcode/combat/region/worldguard/WorldGuardRegionProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ private boolean isCombatRegion(ProtectedRegion region) {
@Nullable
private ProtectedRegion highestPriorityRegion(ApplicableRegionSet applicableRegions) {
return applicableRegions.getRegions().stream()
.min(Comparator.comparingInt(ProtectedRegion::getPriority))
.max(Comparator.comparingInt(ProtectedRegion::getPriority))
.orElse(null);
}
Comment on lines 85 to 90
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This method can be improved by returning an Optional<ProtectedRegion> instead of using @Nullable. This change aligns with modern Java best practices for handling potentially absent values, making the code safer by leveraging the type system to enforce checks for presence and eliminating the risk of NullPointerException from an unchecked null return. It also enables callers, such as the getRegion method, to use a more fluent and declarative style with Optional chaining.

    private Optional<ProtectedRegion> highestPriorityRegion(ApplicableRegionSet applicableRegions) {
        return applicableRegions.getRegions().stream()
            .max(Comparator.comparingInt(ProtectedRegion::getPriority));
    }


Expand Down
Loading