GH-188 Add support for folia-based servers. #275

vLuckyyy · 2025-09-15T20:35:30Z

No description provided.

# Conflicts: # buildSrc/src/main/kotlin/Versions.kt

gemini-code-assist

Summary of Changes

Hello @vLuckyyy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the plugin's compatibility by adding robust support for Folia-based Minecraft servers. It achieves this through a new adaptive scheduling system that intelligently detects the server environment and utilizes the appropriate scheduler, alongside necessary dependency updates and build configuration adjustments to ensure seamless operation on both traditional Bukkit/Paper and modern Folia platforms.

Highlights

Folia Server Support: Introduced support for Folia-based Minecraft servers by implementing an adaptive scheduler that dynamically selects between Bukkit and Folia scheduling mechanisms based on the server environment.
Dependency Updates and Additions: Updated the LITE_COMMANDS library to version 3.10.5 and added new dependencies: litecommands-folia, eternalcode-commons-folia, and eternalcode-commons-shared to facilitate Folia compatibility.
Scheduler Abstraction: Refactored the core scheduling logic by introducing a MinecraftScheduler interface and an adaptive CombatSchedulerAdapter, replacing direct BukkitSchedulerImpl usage across various services like BorderServiceImpl, BorderTriggerIndex, and KnockbackService.
Build Configuration Enhancements: Modified the build.gradle.kts to explicitly declare foliaSupported = true and adjusted the shadowJar relocation rule for io.papermc to io.papermc.lib.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces support for Folia-based servers by adding an adaptive scheduler, updating dependencies, and modifying task scheduling to be Folia-compatible. The approach is solid and correctly uses a runtime check to select the appropriate scheduler implementation. My review focuses on a potential high-severity issue in the knockback logic where a change made for Folia compatibility might lead to players being teleported into blocks. I've also included some medium-severity suggestions to improve the code quality of the new scheduler adapter class by adhering to common Java best practices for utility classes.

gemini-code-assist · 2025-09-15T20:37:21Z

eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/knockback/Point2D.java

    Location toLocation(Location location) {
        World world = location.getWorld();
-        int y = world.getHighestBlockYAt(x, z) + 1;
+        double y = location.getY();


By preserving the player's Y-coordinate, you risk teleporting them inside blocks or terrain if the new X/Z coordinates are inside a wall or mountain. The previous implementation using world.getHighestBlockYAt(x, z) was safer in the vertical axis. While getHighestBlockYAt is a synchronous call and problematic on Folia, simply using the existing Y-coordinate is dangerous and can lead to players getting stuck or taking suffocation damage. Consider finding a safe location to teleport the player to, which might involve checking for solid blocks at the target location or using an async-safe method to find the highest block.

will do research on this

eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatSchedulerAdapter.java

…atSchedulerAdapter.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

CitralFlo · 2025-09-16T08:04:45Z

eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/knockback/KnockbackService.java

        insideRegion.put(player.getUniqueId(), region);
-        scheduler.runLater(() -> {
+
+        scheduler.runLater(player.getLocation(), () -> {


if this player.getLocation() is here, can it be removed in the next line?

Jakubk15 · 2025-09-18T17:15:37Z

eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/knockback/Point2D.java

    Location toLocation(Location location) {
        World world = location.getWorld();
-        int y = world.getHighestBlockYAt(x, z) + 1;
+        double y = location.getY();


will do research on this

Jakubk15 · 2025-09-18T17:17:20Z

eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatSchedulerAdapter.java

+    private static final String FOLIA_CLASS = "io.papermc.paper.threadedregions.RegionizedServer";
+
+    private CombatSchedulerAdapter() {
+        throw new IllegalStateException("You can't instantiate this class");


Suggested change

throw new IllegalStateException("You can't instantiate this class");

throw new UnsupportedOperationException("This is an utility class and cannot be instantiated");

nitpick, but it's a standard in our utility classes

vLuckyyy added 2 commits August 30, 2025 22:41

Release v2.3.0-SNAPSHOT

952551b

Merge remote-tracking branch 'origin/master' into folia-cooking

6a07b94

# Conflicts: # buildSrc/src/main/kotlin/Versions.kt

gemini-code-assist bot reviewed Sep 15, 2025

View reviewed changes

vLuckyyy requested review from Rollczi, igoyek, Jakubk15, CitralFlo and imDMK September 15, 2025 20:36

gemini-code-assist bot reviewed Sep 15, 2025

View reviewed changes

vLuckyyy and others added 3 commits September 15, 2025 22:37

Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/Comb…

ec8208a

…atSchedulerAdapter.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Make CombatSchedulerAdapter uninstantiable.

e252c7f

Merge branch 'master' into folia-cooking

d349352

CitralFlo reviewed Sep 16, 2025

View reviewed changes

imDMK approved these changes Sep 16, 2025

View reviewed changes

igoyek approved these changes Sep 17, 2025

View reviewed changes

Jakubk15 reviewed Sep 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

GH-188 Add support for folia-based servers. #275

GH-188 Add support for folia-based servers. #275

vLuckyyy commented Sep 15, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 15, 2025

Uh oh!

Jakubk15 Sep 18, 2025

Uh oh!

Uh oh!

Uh oh!

CitralFlo Sep 16, 2025

Uh oh!

Jakubk15 Sep 18, 2025

Uh oh!

Jakubk15 Sep 18, 2025

Uh oh!

Uh oh!

	throw new IllegalStateException("You can't instantiate this class");
	throw new UnsupportedOperationException("This is an utility class and cannot be instantiated");

Uh oh!

GH-188 Add support for folia-based servers. #275

Are you sure you want to change the base?

GH-188 Add support for folia-based servers. #275

Conversation

vLuckyyy commented Sep 15, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CitralFlo Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!