GH-1051 Add integrational tests #1051
Conversation
|
Warning Rate limit exceeded@vLuckyyy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 19 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughA new workflow has been added to automatically test a Minecraft plugin with several Minecraft server versions using GitHub Actions. This workflow runs when changes are pushed to the master branch or when pull requests are opened or updated. It builds the plugin, sets up a server environment for each specified Minecraft version, installs the plugin, and checks the server log for errors after startup. If any issues are found, the workflow reports them; otherwise, it confirms successful compatibility for each version tested. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
📦 Development Build ReadyWarning Do not use this build in production. It is for testing purposes only and may be unstable. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/test-mc-versions.yml (1)
82-91: 60 s may be tight for first bootPaper’s first start can exceed a minute, especially on slower hardware.
Consider waiting until “Done” appears or bumping the timeout to be safe.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test-mc-versions.yml(1 hunks)
🔇 Additional comments (2)
.github/workflows/test-mc-versions.yml (2)
47-53: Confirmjqexists or install it firstThe step pipes the API output through
jq, but the workflow never ensuresjqis present.
Many self-hosted runners don’t have it by default.Quick fix:
- run: | + run: | + sudo apt-get update && sudo apt-get install -y jq BUILD_NUMBER=$(curl -s "https://api.papermc.io/v2/projects/paper/versions/${MC_VERSION}/builds" \ | jq '.builds | max_by(.build) | .build')
66-74: Strip leading spaces in generated filesThe here-doc is indented, so every line in
server.propertiesstarts with spaces.
Some keys are ignored when prefixed with whitespace.- cat > mc-server/server.properties <<EOF + cat > mc-server/server.properties <<'EOF' server-port=${MC_PORT} allow-nether=false level-type=FLAT max-world-size=16 EOFDo the same for
bukkit.ymlbelow.Likely an incorrect or invalid review comment.
Jakubk15
changed the title
|
Rollczi is cooking that |
No description provided.