Skip to content

GH-1075 Add /tprp for caves. Move tprp feature to own section. #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2025
Merged

GH-1075 Add /tprp for caves. Move tprp feature to own section. #1077

merged 5 commits into from
Aug 12, 2025

Conversation

vLuckyyy
Copy link
Member

Fixes #1075

@vLuckyyy vLuckyyy requested a review from a team as a code owner July 29, 2025 22:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2025 •
edited
Loading

📦 Development Build Ready

Warning

Do not use this build in production. It is for testing purposes only and may be unstable.

👉 Click here to download the JAR

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 29, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new command /tprp <minY> <maxY> to teleport to players within a specific Y-range, useful for moderation in caves. It refactors the random player teleport feature into its own configuration and message section, improving modularity. The review identified redundant logic in command handlers, duplicated/unused message keys, and unused imports. Addressing this feedback will enhance code quality and maintainability.

@vLuckyyy vLuckyyy changed the title Add /tprp for caves. Move tprp feature to own section. GH-1075 Add /tprp for caves. Move tprp feature to own section. Aug 10, 2025
CitralFlo
CitralFlo approved these changes Aug 11, 2025
View reviewed changes
@vLuckyyy vLuckyyy merged commit 5a48403 into master Aug 12, 2025
2 checks passed
@vLuckyyy vLuckyyy deleted the add-tprp-for-cave branch August 12, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@P1otrulla P1otrulla P1otrulla approved these changes

@CitralFlo CitralFlo CitralFlo approved these changes

@Jakubk15 Jakubk15 Awaiting requested review from Jakubk15

@imDMK imDMK Awaiting requested review from imDMK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add minY, maxY arguments to /tprp command
3 participants
@vLuckyyy @P1otrulla @CitralFlo