GH-999 Add end screen command #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced the end screen overlay functionality, including the EndScreenCommand for showing the end screen to self or another player. Added English and Polish message translations for the end screen, updated the Translation interface and implementations, and extended PaperOverlay to support the new end screen.
📦 Development Build ReadyWarning Do not use this build in production. It is for testing purposes only and may be unstable. |
Closed
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new /endscreen command, allowing players to show the win screen to themselves or others. The implementation is well-structured, including internationalization support for messages. I've made a couple of suggestions to improve consistency in naming and message formatting. The included refactoring of PaperFeature to remove an unused generic is a good improvement.
eternalcore-core/src/main/java/com/eternalcode/core/feature/fun/endscreen/EndScreenCommand.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/eternalcode/core/feature/fun/endscreen/messages/ENEndScreenMessages.java
Outdated
Show resolved
Hide resolved
…n/endscreen/messages/ENEndScreenMessages.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…/end-screen-command
vLuckyyy
approved these changes
Aug 11, 2025
eternalcore-core/src/main/java/com/eternalcode/core/feature/fun/endscreen/EndScreenCommand.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/fun/endscreen/EndScreenCommand.java
Show resolved
Hide resolved
eternalcore-paper/src/main/java/com/eternalcode/paper/PaperOverlay.java
Outdated
Show resolved
Hide resolved
CitralFlo
requested changes
Aug 11, 2025
...e/src/main/java/com/eternalcode/core/feature/fun/endscreen/messages/ENEndScreenMessages.java
Show resolved
Hide resolved
...e/src/main/java/com/eternalcode/core/feature/fun/endscreen/messages/PLEndScreenMessages.java
Show resolved
Hide resolved
vLuckyyy
approved these changes
Aug 11, 2025
CitralFlo
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.