GH-1147 Make UserManager use UserRepository #1147

CitralFlo · 2025-08-30T20:27:34Z

Methods do not change so #1136 can be merged :>

gemini-code-assist

Code Review

This pull request refactors the UserManager to use a repository pattern for data persistence, which is a great improvement. I've identified a few issues, including a critical bug that causes double database writes and a race condition during initial data loading. Additionally, there are opportunities to improve code clarity and maintainability by simplifying some logic and improving API design. The new integration tests are a good addition, but could be improved by removing console output.

eternalcore-core/src/main/java/com/eternalcode/core/user/UserManager.java

buildSrc/src/main/kotlin/eternalcode-java-test.gradle.kts

eternalcore-core/src/main/java/com/eternalcode/core/user/UserManager.java

eternalcore-core/src/main/java/com/eternalcode/core/user/database/UserRepository.java

eternalcore-core/src/main/java/com/eternalcode/core/user/database/UserRepositoryOrmLite.java

eternalcore-core/src/test/java/com/eternalcode/core/user/BatchTest.java

eternalcore-core/src/test/java/com/eternalcode/core/user/UserBatchFetchTest.java

sadcenter

LGTM

eternalcore-core/src/main/java/com/eternalcode/core/user/database/UserRepositoryOrmLite.java

…-manager-database

# Conflicts: # buildSrc/src/main/kotlin/Versions.kt # eternalcore-core/src/main/java/com/eternalcode/core/feature/fullserverbypass/FullServerBypassController.java # eternalcore-core/src/main/java/com/eternalcode/core/user/UserClientBukkitSettings.java

Rollczi

chyba tam testy wybuchają i takie tam

eternalcore-core/src/main/java/com/eternalcode/core/database/DatabaseConfig.java

eternalcore-core/src/main/java/com/eternalcode/core/database/DatabaseDriverType.java

eternalcore-core/src/main/java/com/eternalcode/core/user/UserController.java

…ation, remove unused methods, and streamline cache handling.

…uration, and streamline ORM functionality.

Rollczi

Część CR masz w commit - poprawki estetyczne - duplikacje i takie tam pierdoły.
Mam pewne pytania gdzie trochę nie jestem pewien intencji to zostawiam do twojej weryfikacji:

jakieś rzeczy w user manager
testy

eternalcore-core/src/main/java/com/eternalcode/core/user/database/UserRepositoryImpl.java

eternalcore-core/src/main/java/com/eternalcode/core/user/UserManager.java

eternalcore-core/src/test/java/com/eternalcode/core/util/TestScheduler.java

…methods, and simplify `UserManager` logic.

…e no longer used.

imDMK · 2025-12-02T14:41:28Z

eternalcore-core/src/main/java/com/eternalcode/core/feature/afk/AfkKickController.java

+        Optional<User> optionalUser = this.userManager.getUser(playerUUID);
+        User user = optionalUser.get();


Suggested change

Optional<User> optionalUser = this.userManager.getUser(playerUUID);

User user = optionalUser.get();

User user = this.userManager.getUser(playerUUID).orElseThrow();

imDMK · 2025-12-02T14:41:37Z

eternalcore-core/src/main/java/com/eternalcode/core/feature/msg/MsgServiceImpl.java

        UserManager userManager,
        EventCaller eventCaller,
-        MsgToggleService msgToggleService
+        MsgToggleService msgToggleService, Server server


Suggested change

MsgToggleService msgToggleService, Server server

MsgToggleService msgToggleService,

Server server

imDMK · 2025-12-02T14:42:30Z

eternalcore-core/src/main/java/com/eternalcode/core/feature/msg/MsgServiceImpl.java

+        UUID uuid = this.replies.getIfPresent(sender.getUniqueId());
+
+        if (uuid == null) {
+            this.noticeService.player(sender.getUniqueId(), translation -> translation.msg().noReply());
+
+            return;
+        }
+
+        Player target = this.server.getPlayer(uuid);


Suggested change

UUID uuid = this.replies.getIfPresent(sender.getUniqueId());

if (uuid == null) {

this.noticeService.player(sender.getUniqueId(), translation -> translation.msg().noReply());

return;

}

Player target = this.server.getPlayer(uuid);

UUID lastReplyUuid = this.replies.getIfPresent(sender.getUniqueId());

if (lastReplyUuid == null) {

this.noticeService.player(sender.getUniqueId(), translation -> translation.msg().noReply());

return;

}

Player lastReply= this.server.getPlayer(lastReplyUuid );

CitralFlo added 2 commits August 30, 2025 22:10

Add database for users, add batch fetching, update tests

92868fe

Codestyle fixes

1a7dd18

CitralFlo requested a review from a team as a code owner August 30, 2025 20:27

CitralFlo changed the title ~~User Manager uses repository now!~~ GH-1147 User Manager uses repository now! Aug 30, 2025

gemini-code-assist bot reviewed Aug 30, 2025

View reviewed changes

Resolve gemini review

3c6ad2a

Jakubk15 reviewed Aug 31, 2025

View reviewed changes

eternalcore-core/src/test/java/com/eternalcode/core/user/UserBatchFetchTest.java Outdated Show resolved Hide resolved

sadcenter reviewed Aug 31, 2025

View reviewed changes

eternalcore-core/src/test/java/com/eternalcode/core/user/UserBatchFetchTest.java Outdated Show resolved Hide resolved

Resolve @sadcenter and @Jakubk15 reviews

7d3ee9e

CitralFlo requested a review from sadcenter September 1, 2025 19:59

wip

9414f7d

CitralFlo marked this pull request as draft September 1, 2025 21:29

sadcenter approved these changes Sep 6, 2025

View reviewed changes

eternalcore-core/src/main/java/com/eternalcode/core/user/database/UserRepositoryOrmLite.java Outdated Show resolved Hide resolved

CitralFlo added 2 commits September 13, 2025 08:58

wip2

b3efc5f

Merge remote-tracking branch 'origin/user-manager-database' into user…

2050371

…-manager-database

Jakubk15 changed the title ~~GH-1147 User Manager uses repository now!~~ GH-1147 Make UserManager use UserRepository Sep 28, 2025

CitralFlo and others added 3 commits October 5, 2025 17:22

wip

0cdf8b2

Update methods and failsafe for cache

11813d4

Rollczi requested changes Oct 26, 2025

View reviewed changes

vLuckyyy added 3 commits November 29, 2025 23:27

Merge branch 'master' into user-manager-database

c3aa70a

Refactor UserManager and related classes to improve database integr…

80730a5

…ation, remove unused methods, and streamline cache handling.

Remove MySQL and Testcontainers integration, refactor database config…

2e0a7e1

…uration, and streamline ORM functionality.

vLuckyyy marked this pull request as ready for review November 30, 2025 17:40

vLuckyyy requested review from Jakubk15, P1otrulla, Rollczi and imDMK November 30, 2025 17:40

Rollczi requested changes Nov 30, 2025

View reviewed changes

CR

5cebc63

vLuckyyy added 2 commits December 1, 2025 19:56

Remove created and lastLogin fields from User, cleanup related …

5f086ae

…methods, and simplify `UserManager` logic.

Remove IntegrationTestSpec and TestScheduler utilities as they ar…

d42de10

…e no longer used.

imDMK reviewed Dec 2, 2025

View reviewed changes

		Optional<User> optionalUser = this.userManager.getUser(playerUUID);
		User user = optionalUser.get();

	Optional<User> optionalUser = this.userManager.getUser(playerUUID);
	User user = optionalUser.get();
	User user = this.userManager.getUser(playerUUID).orElseThrow();

	MsgToggleService msgToggleService, Server server
	MsgToggleService msgToggleService,
	Server server

Uh oh!

GH-1147 Make UserManager use UserRepository #1147

Are you sure you want to change the base?

GH-1147 Make UserManager use UserRepository #1147

Conversation

CitralFlo commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sadcenter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rollczi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Rollczi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imDMK Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

imDMK Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

imDMK Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

CitralFlo commented Aug 30, 2025 •

edited

Loading