Notice`s package-private

[Pawelusze]

Make Notice`s package-private

[gemini-code-assist]

Code Review

This pull request primarily refactors message classes to use package-private visibility for Notice fields, improving encapsulation. It also consolidates sound-playing logic for join, quit, and chat events into their respective controllers, which is a good structural improvement.

However, I've found a critical issue in BroadcastCommand where the executeTitle method has been refactored in a way that breaks its functionality by not replacing placeholders and introducing confusing behavior. I've also spotted a minor typo in the gradlew script. My detailed feedback and suggestions are in the comments below.

[gemini-code-assist]

The new implementation of executeTitle seems to have a few issues:

1. Placeholder Not Replaced: The title is set from translation.broadcast().messageFormat() when not in raw mode. This format string likely contains placeholders like {BROADCAST} which are not being replaced. This will result in players seeing the literal placeholder string.
2. Unclear Functionality: The command has been changed to broadcast a "combined title message", and executeSubtitle has been removed. However, the implementation always uses the input text as the subtitle, and the title is either a space or the unformatted format string. This is a confusing and likely incorrect behavior. It's also a breaking change that isn't documented in the PR description.

If the intention is for this command to now broadcast a subtitle (as executeSubtitle was removed), you could reuse the sendBroadcast helper method which correctly handles placeholder replacement.

Here is a suggested implementation that would make /broadcast title behave like the old /broadcast subtitle:

Suggested change

	this.noticeService.create()
	.notice(translation -> Notice.title(raw ? " " : translation.broadcast().messageFormat(), text,
	this.settings.titleFadeIn(), this.settings.titleStay(), this.settings.titleFadeOut()))
	.onlinePlayers()
	.send();
	this.sendBroadcast(
	formatted -> Notice.title("", formatted, this.settings.titleFadeIn(), this.settings.titleStay(), this.settings.titleFadeOut()),
	text,
	raw
	);