GH-37 Implement /withdraw command for physical banknote withdrawal #89
+810
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k command, and implement paycheck listener
…e dependencies for improved clarity and functionality
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a feature for players to withdraw in-game currency as physical items (checks). The implementation is mostly solid, but there are several critical and high-severity issues that need to be addressed. These include a bug that could cause players to lose items, potential data precision loss in the economy, incorrect permission setup, and a bug in argument parsing. I've also included some medium-severity suggestions to improve code quality and consistency.
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawService.java
Outdated
Show resolved
Hide resolved
...onomy-core/src/main/java/com/eternalcode/economy/command/argument/PriceArgumentResolver.java
Outdated
Show resolved
Hide resolved
...onomy-core/src/main/java/com/eternalcode/economy/command/argument/PriceArgumentResolver.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawCommand.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawService.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawTagger.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawTagger.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/EconomyBukkitPlugin.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/com/eternalcode/economy/config/implementation/messages/MessageConfig.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawListener.java
Outdated
Show resolved
Hide resolved
Jakubk15
approved these changes
Oct 12, 2025
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawManager.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawService.java
Outdated
Show resolved
Hide resolved
Member
|
And please, please adjust to Gemini's suggestions! |
P1otrulla
requested changes
Oct 12, 2025
Member
P1otrulla
left a comment
P1otrulla
left a comment
There was a problem hiding this comment.
Good job, but you need to clean up some things.
Change spigot API for paper and remove this hacks about display name etc.
We use Bukkit#getPlayer... only in utils etc -> use normal instance of server like Server#getPlayer
Add function to block renaming check as i told you on voice chat as we're talking about it.
...leconomy-core/src/main/java/com/eternalcode/economy/command/impl/admin/AdminItemCommand.java
Outdated
Show resolved
Hide resolved
...leconomy-core/src/main/java/com/eternalcode/economy/command/impl/admin/AdminItemCommand.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawListener.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawCommand.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawCommand.java
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawManager.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawManager.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawManager.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawManager.java
Outdated
Show resolved
Hide resolved
vLuckyyy
requested changes
Oct 12, 2025
eternaleconomy-core/src/main/java/com/eternalcode/economy/EconomyPermissionConstant.java
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawCommand.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawTagger.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawTagger.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawTagger.java
Outdated
Show resolved
Hide resolved
...n/java/com/eternalcode/economy/config/implementation/messages/MessagePaycheckSubSection.java
Outdated
Show resolved
Hide resolved
...n/java/com/eternalcode/economy/config/implementation/messages/MessagePaycheckSubSection.java
Outdated
Show resolved
Hide resolved
...n/java/com/eternalcode/economy/config/implementation/messages/MessagePaycheckSubSection.java
Outdated
Show resolved
Hide resolved
...aleconomy-core/src/main/java/com/eternalcode/economy/config/implementation/PluginConfig.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawListener.java
Outdated
Show resolved
Hide resolved
…plement new withdraw functionality + Support blocking anvil interactions
…ment parsing, and enhance admin commands
…m setup logic, and improve inventory interaction messages
… to ensure prices are greater than 0.09
…ceArgumentResolver for consistency across commands
…R if currency item is AIR
imDMK
reviewed
Oct 14, 2025
...onomy-core/src/main/java/com/eternalcode/economy/command/argument/PriceArgumentResolver.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/com/eternalcode/economy/config/implementation/messages/MessageConfig.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawItemService.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawMessageConfig.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/com/eternalcode/economy/withdraw/controller/WithdrawAnvilController.java
Outdated
Show resolved
Hide resolved
P1otrulla
requested changes
Oct 14, 2025
Member
P1otrulla
left a comment
P1otrulla
left a comment
There was a problem hiding this comment.
Zrób reoznaczenie mnie jak skaczysz robić tego prka
…eImpl class for banknote handling. Add ConfigItem object to handle withdraw item properly
…figItem for better item handling and improve code readability
… of custom model data
CitralFlo
requested changes
Oct 17, 2025
eternaleconomy-core/src/main/java/com/eternalcode/economy/EconomyBukkitPlugin.java
Outdated
Show resolved
Hide resolved
...onomy-core/src/main/java/com/eternalcode/economy/command/argument/PriceArgumentResolver.java
Outdated
Show resolved
Hide resolved
...onomy-core/src/main/java/com/eternalcode/economy/command/argument/PriceArgumentResolver.java
Outdated
Show resolved
Hide resolved
...onomy-core/src/main/java/com/eternalcode/economy/command/argument/PriceArgumentResolver.java
Outdated
Show resolved
Hide resolved
...onomy-core/src/main/java/com/eternalcode/economy/command/argument/PriceArgumentResolver.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/com/eternalcode/economy/config/implementation/messages/MessageConfig.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawItemServiceImpl.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawItemServiceImpl.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawService.java
Outdated
Show resolved
Hide resolved
…h MoneyFormatArgument for improved money value parsing
…dability and consistency
vLuckyyy
changed the title
imDMK
requested changes
Oct 30, 2025
eternaleconomy-core/src/main/java/com/eternalcode/economy/config/item/ConfigItem.java
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/config/item/ConfigItem.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/config/item/ConfigItem.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawItemServiceImpl.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawItemServiceImpl.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawItemServiceImpl.java
Outdated
Show resolved
Hide resolved
eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawItemServiceImpl.java
Outdated
Show resolved
Hide resolved
P1otrulla
approved these changes
Nov 8, 2025
CitralFlo
requested changes
Nov 30, 2025
Member
CitralFlo
left a comment
CitralFlo
left a comment
There was a problem hiding this comment.
Rollback changes regarding Argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.