Fix URL Opening from Share Extension on iOS 18+#36
Open
martatesar wants to merge 3 commits intoEternallLight:masterfrom
Open
Fix URL Opening from Share Extension on iOS 18+#36martatesar wants to merge 3 commits intoEternallLight:masterfrom
martatesar wants to merge 3 commits intoEternallLight:masterfrom
Conversation
…ller Implemented openURLModern to handle URL opening in a way that supports iOS 18.0 and later, while maintaining compatibility with earlier versions. Updated sendResults method to utilize the new openURLModern method for better performance and reliability.
…ndling Replaced the openURLModern method with a simplified openURL implementation to enhance URL handling in ShareViewController. Updated the sendResults method to call the new openURL method, ensuring consistent behavior across iOS versions.
Enhance error handling in willMoveToParentViewController method Updated the willMoveToParentViewController method in ShareViewController to include error handling when accessing the _hostBundleID property. Added debug and warning logs to improve traceability and maintain functionality across iOS versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the implementation to support opening URLs from the share extension on iOS 18 and above.
Replaced the deprecated openURL approach with a method adapted from this Stack Overflow solution, translated to Objective-C.