-
Notifications
You must be signed in to change notification settings - Fork 72
New Sections component and Layouts clean up. #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview available
|
|
I like the idea of having a wider main frame, but without headers and content centered, the page looks off and asymmetrical: I don't think that simply centering the headers would fix the issue, though. We have text-heavy pages where centered headers might also look weird, for example: I do think widening the main frame is an important feature to implement, but it probably needs a bit more design work and some rearrangement of other components to better fit the new layout. |
This can change when we will have sticky header, there will be better visual separation.
We can stay with old width, all other changes are still valid and we can go with them if there is no new issues. |
clytaemnestra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clytaemnestra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.



Improvements related to issue #1139 which makes switch to wide layout simple.