Skip to content

Conversation

@nikoshell
Copy link
Contributor

@nikoshell nikoshell commented Apr 26, 2025

Improvements related to issue #1139 which makes switch to wide layout simple.

@europython-society
Copy link
Member

europython-society commented Apr 26, 2025

Preview available

Key Value
url https://ep2025-layout-v2.ep-preview.click
last update 2025-05-05T10:23:17.025Z

@nikoshell nikoshell requested a review from clytaemnestra April 26, 2025 17:49
@clytaemnestra
Copy link
Contributor

I like the idea of having a wider main frame, but without headers and content centered, the page looks off and asymmetrical:

image

I don't think that simply centering the headers would fix the issue, though. We have text-heavy pages where centered headers might also look weird, for example:

image


I do think widening the main frame is an important feature to implement, but it probably needs a bit more design work and some rearrangement of other components to better fit the new layout.

@egeakman egeakman added DO-NOT-MERGE Not ready to be merged yet enhancement New feature or request labels Apr 28, 2025
@nikoshell nikoshell removed enhancement New feature or request DO-NOT-MERGE Not ready to be merged yet labels May 2, 2025
@nikoshell
Copy link
Contributor Author

nikoshell commented May 2, 2025

I like the idea of having a wider main frame, but without headers and content centered, the page looks off and asymmetrical:

This can change when we will have sticky header, there will be better visual separation.

I do think widening the main frame is an important feature to implement, but it probably needs a bit more design work and some rearrangement of other components to better fit the new layout.

We can stay with old width, all other changes are still valid and we can go with them if there is no new issues.
New section component and layouts clean up makes ease to change width for all pages.

@nikoshell nikoshell changed the title Change layout to wide. New Sections component and Layouts clean up. May 2, 2025
@nikoshell nikoshell requested a review from egeakman May 4, 2025 08:57
Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional or a mistake? I think the previous ones, without an anchor, looked better. Wdyt?

image

Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@nikoshell nikoshell merged commit 9569b27 into ep2025 May 5, 2025
6 checks passed
@nikoshell nikoshell deleted the ep2025-layout-v2 branch May 5, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants