Sort community partners #1221
Merged
Sort community partners #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Preview available
|
hugovk
force-pushed
the
sort-community-partners
branch
from
f42643b to
06eb618
Compare
egeakman
approved these changes
May 12, 2025
Member
egeakman
left a comment
egeakman
left a comment
There was a problem hiding this comment.
Thanks Hugo! I think this works.
Contributor
clytaemnestra
left a comment
clytaemnestra
left a comment
There was a problem hiding this comment.
It's still not alphabetical -- Italy should come before Portugal.
Member
Author
|
Italy comes before Portugal on the preview: https://sort-community-partners.ep-preview.click/community-partners/ Maybe you checked the live site? :) |
clytaemnestra
approved these changes
May 13, 2025
Contributor
clytaemnestra
left a comment
clytaemnestra
left a comment
There was a problem hiding this comment.
@hugovk, sorry, it was the correct page, but I had it cached! LGTM! Thanks!
thepetk
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ep2025.europython.eu/community-partners/ says they're in alphabetical order, but they're not. For example, PyCon Italia is shown before PyCon France.
This PR sorts them by ID, which is their directory name. Not exactly the same as sorting by name, but close enough?