YouTube player for markdown #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Preview available
|
Co-authored-by: Mia Bajić <[email protected]>
clytaemnestra
approved these changes
Jun 8, 2025
egeakman
approved these changes
Jun 8, 2025
Member
egeakman
left a comment
egeakman
left a comment
There was a problem hiding this comment.
Thank you Marcin!! One small question below:
egeakman
reviewed
Jun 8, 2025
astro.config.mjs
Outdated
| } | ||
| } | ||
|
|
||
| const fastBuild = false; |
Member
There was a problem hiding this comment.
Can we make this passable like --mode? It's fine to add it in another PR.
Contributor
Author
There was a problem hiding this comment.
mode is astro argument, technically we can override it but there is no reason for that
I can do it as new flag.
Member
There was a problem hiding this comment.
Yeah yeah, I meant as a new flag, similar to how we implemented --mode.
Contributor
Author
There was a problem hiding this comment.
I add it already as env variable EP_FAST_BUILD and set to true in dotenv for development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New YouTube component which can be also used in any markdown content.
YT links are replaced with player.