-
Notifications
You must be signed in to change notification settings - Fork 72
Sprints page with filter #1383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprints page with filter #1383
Conversation
Preview available
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
rodrigogiraoserrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me in principle but I'd love if someone could reassure me w.r.t. the fact that the preview, when open on the sprints weekend page, only shows the sprints cards and doesn't show the other info that's already live on the website.
|
(Also, I've added stubs for the CPython & BeeWare project sprints and I'll reach out to the folks I talked to initially to get their email addresses/full descriptions for their project cards.) |
Correct this is the goal, I will update PR to have correct preview view. |
egeakman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Marcin! Looks good to merge.
Let's add a notice on how to add a new project on this page in the next PR.
rodrigogiraoserrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there two “sprints template” files, the _sprints_template.md and the sprints_template.md?
Also, in _sprints_template.md, why do we instruct folks who make the PRs to keep draft: true in the project they're adding?
If they're adding it, it's not supposed to be a draft; it's supposed to be live.
(Maybe I misunderstood the point of draft: true.)
We use draft flag in multiple places to manage content, it's useful in case when we want commit but not publish content, when it is finial we need to remove it. Content with draft: true is visible with watermark on not prod environments including preview environment. _sprints_template.md is a template and we need to prepare description how to use it. |
Uh oh!
There was an error while loading. Please reload this page.