Skip to content

Conversation

@nikoshell
Copy link
Contributor

@nikoshell nikoshell commented Jul 2, 2025

image

@nikoshell nikoshell self-assigned this Jul 2, 2025
@europython-society
Copy link
Member

europython-society commented Jul 2, 2025

Preview available

Key Value
url https://ep2025-sprints.ep-preview.click
last update 2025-07-09T18:02:20.128Z

@rodrigogiraoserrao rodrigogiraoserrao marked this pull request as ready for review July 6, 2025 16:25
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me in principle but I'd love if someone could reassure me w.r.t. the fact that the preview, when open on the sprints weekend page, only shows the sprints cards and doesn't show the other info that's already live on the website.

@rodrigogiraoserrao
Copy link
Contributor

(Also, I've added stubs for the CPython & BeeWare project sprints and I'll reach out to the folks I talked to initially to get their email addresses/full descriptions for their project cards.)

@nikoshell
Copy link
Contributor Author

This looks good to me in principle but I'd love if someone could reassure me w.r.t. the fact that the preview, when open on the sprints weekend page, only shows the sprints cards and doesn't show the other info that's already live on the website.

Correct this is the goal, I will update PR to have correct preview view.

Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marcin! Looks good to merge.

Let's add a notice on how to add a new project on this page in the next PR.

Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there two “sprints template” files, the _sprints_template.md and the sprints_template.md?

Also, in _sprints_template.md, why do we instruct folks who make the PRs to keep draft: true in the project they're adding?
If they're adding it, it's not supposed to be a draft; it's supposed to be live.
(Maybe I misunderstood the point of draft: true.)

@nikoshell nikoshell changed the title Sprints page with example data Sprints page with filter Jul 8, 2025
@nikoshell
Copy link
Contributor Author

Why are there two “sprints template” files, the _sprints_template.md and the sprints_template.md?

Also, in _sprints_template.md, why do we instruct folks who make the PRs to keep draft: true in the project they're adding? If they're adding it, it's not supposed to be a draft; it's supposed to be live. (Maybe I misunderstood the point of draft: true.)

We use draft flag in multiple places to manage content, it's useful in case when we want commit but not publish content, when it is finial we need to remove it. Content with draft: true is visible with watermark on not prod environments including preview environment.

_sprints_template.md is a template and we need to prepare description how to use it.
sprints_template.md renamed to example_draft.md was created to show how draft looks on preview and it's not visible on prod

@nikoshell nikoshell merged commit 46d04cb into ep2025 Jul 9, 2025
5 checks passed
@nikoshell nikoshell deleted the ep2025-sprints branch July 9, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants