Skip to content

Add deployment automation #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jan 20, 2025
Merged

Add deployment automation #961

merged 18 commits into from
Jan 20, 2025

Conversation

@egeakman
Copy link
Member

@egeakman egeakman commented Jan 15, 2025 •
edited
Loading

  • This does not include clearing the temp directory. We should set a cron job for that.
  • Also the previews directory might need some cleaning too after a while, but I guess that's something to discuss elsewhere.
  • The files are copied to a temp directory from local machine (or runner), then copied to their final destination (within the static server). This is as atomic as I could get it (and most likely should be enough).

@egeakman egeakman requested review from artcz and cybit January 15, 2025 07:24
@egeakman egeakman self-assigned this Jan 15, 2025
cybit
cybit requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@cybit cybit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot is linting.
Some is don't reinvent.
Some is missing.

cybit
cybit reviewed Jan 17, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

Preview available

Key Value
url https://deployment.ep-preview.click
last update 2025-01-20T16:33:51.703Z

egeakman and others added 17 commits January 20, 2025 17:24
cybit
cybit approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@cybit cybit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing about moving the version information directly beneath the links in the footer. But that is not neccessary.

@artcz artcz merged commit 3f39516 into ep2025 Jan 20, 2025
4 checks passed
@artcz artcz deleted the deployment branch January 20, 2025 16:35
@egeakman egeakman restored the deployment branch February 24, 2025 16:49
egeakman added a commit that referenced this pull request Feb 24, 2025
@egeakman @cybit
@pre-commit-ci @artcz
Add deployment automation (#961)
aaeea8d 
---------

Co-authored-by: Cyril Bitterich <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Artur Czepiel <[email protected]>
@egeakman egeakman deleted the deployment branch March 10, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cybit cybit cybit approved these changes

@artcz artcz Awaiting requested review from artcz

Assignees

@egeakman egeakman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@egeakman @artcz @cybit