-
Notifications
You must be signed in to change notification settings - Fork 72
Add C API Summit #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C API Summit #995
Conversation
for more information, see https://pre-commit.ci
Preview available
|
|
Ah OK, the issue is that the page needs to be in @yuliabarabash2601 if you want I can push the fix |
hypha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page used US spelling, which I think is very much OK as it reflects the style of the summit organiser.
|
@egeakman it looks good to me but could you double check if the naming / URL is all good and easy to migrate to pretalx later? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL/naming looks good. One thing I'm not sure about: do we want to keep summits/workshops/sprints (more conference related things) together with social events (PyBurger, Speakers' Dinner, etc.) in the future? I would like to decide this soon, so we don't have to deal with broken links and redirections in the future.
Last year they were all together:

What do you think @hypha @cmaureir @yuliabarabash2601 @cybit?
Hmmm that's a really good question. Now that the wise one asked, I personally think it works better under Programme. But I wonder if @clytaemnestra who is working on the new wireframe for the website UX has any input on this: does it fall under the scope of your work? |
Co-authored-by: hypha <[email protected]>
|
@hypha thanks for the ping! I think it's part of the program. Most people come to the conference because of the program. And people would come to the conference because of the summit. It provides educational value to them. Events, on the other hand, are a nice add-on but not the core of the conference. People would not participate in a conference just because there's a social event. If you want to party, you go to a party. That's how I differentiate it. Also, would it be good to set up a redirect in case we want to promote this on social media? If we move it to the program, the URL will be |
Yeah, we can set up a redirect. But to be honest I wasn't expecting to have this number of redirects, so it may be better to set up a mapping in the code instead of a page for each redirect. For now we can just create that redirection page, and I'll look into how we can do it with a mapping later. |
|
So I think it means if @cmaureir agrees, this PR will include two more changes?
|
This is now done. I'd appreciate a new review so we can merge this soon! |
|
I am confused. The code and content all looks good. But in the preview, the URL is still https://c-api-summit.ep-preview.click/events/c-api-summit/. https://c-api-summit.ep-preview.click/programme/c-api-summit/ is 404, so the redirect also doesn't resolve. I don't know if this is a preview issue or something else is at play here. Maybe @egeakman or @artcz know why? |
|
@hypha https://github.com/EuroPython/website/pull/995/files here everything looks like it's in /events/c-api so the preview looks correct |
|
@artcz! Thanks! I completely missed that! |
hypha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to Artur's tip, fixed the url in a9f6872 and all looks good to me now.
|
Thanks everyone for all the feedback! |
Based off of #995 and #623. The WASM page from last year linked to ticket info but we don't have that page up yet, correct? @ntoll : as agreed, I copied the info from last year. Could you please take a look at this page/the preview and make sure everything looks alright? 🙏 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>


Summit
C API Summit