Skip to content

Conversation

@yuliabarabash2601
Copy link
Contributor

Summit

C API Summit

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Preview available

Key Value
url https://c-api-summit.ep-preview.click
last update 2025-02-11T10:45:06.340Z

@cmaureir
Copy link
Contributor

cmaureir commented Feb 4, 2025

Something seems to be wrong with the preview, I get the following when opening the page
Screenshot 2025-02-04 at 20-20-16

@cmaureir
Copy link
Contributor

cmaureir commented Feb 4, 2025

Ah OK, the issue is that the page needs to be in src/content/pages/.
Also, maybe we create a new events directory there, and we put that inside?
Remember to change the src/data/links.json if you agree to the new directory.

@yuliabarabash2601 if you want I can push the fix

Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page used US spelling, which I think is very much OK as it reflects the style of the summit organiser.

@hypha
Copy link
Contributor

hypha commented Feb 5, 2025

@egeakman it looks good to me but could you double check if the naming / URL is all good and easy to migrate to pretalx later?

@cybit cybit requested a review from egeakman February 7, 2025 11:52
Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL/naming looks good. One thing I'm not sure about: do we want to keep summits/workshops/sprints (more conference related things) together with social events (PyBurger, Speakers' Dinner, etc.) in the future? I would like to decide this soon, so we don't have to deal with broken links and redirections in the future.

Last year they were all together:
image

What do you think @hypha @cmaureir @yuliabarabash2601 @cybit?

@hypha
Copy link
Contributor

hypha commented Feb 7, 2025

One thing I'm not sure about: do we want to keep summits/workshops/sprints (more conference related things) together with social events (PyBurger, Speakers' Dinner, etc.) in the future?

Hmmm that's a really good question. Now that the wise one asked, I personally think it works better under Programme. But I wonder if @clytaemnestra who is working on the new wireframe for the website UX has any input on this: does it fall under the scope of your work?

@clytaemnestra
Copy link
Contributor

@hypha thanks for the ping! I think it's part of the program. Most people come to the conference because of the program. And people would come to the conference because of the summit. It provides educational value to them.

Events, on the other hand, are a nice add-on but not the core of the conference. People would not participate in a conference just because there's a social event. If you want to party, you go to a party. That's how I differentiate it.

Also, would it be good to set up a redirect in case we want to promote this on social media? If we move it to the program, the URL will be europython.eu/programme/c-api-summit - this is very long and doesn't fit well on the screen. It would be nice to have an alias, such as europython.eu/c-api. We did the same for the Call for proposals europython.eu/cfp , Call for reviewers europython.eu/reviewers and planning survey europython.eu/planning . I'm just thinking out loud if this would be good for the C-API summit as well.

@egeakman
Copy link
Member

egeakman commented Feb 9, 2025

Also, would it be good to set up a redirect in case we want to promote this on social media?

Yeah, we can set up a redirect. But to be honest I wasn't expecting to have this number of redirects, so it may be better to set up a mapping in the code instead of a page for each redirect.

For now we can just create that redirection page, and I'll look into how we can do it with a mapping later.

@hypha
Copy link
Contributor

hypha commented Feb 10, 2025

So I think it means if @cmaureir agrees, this PR will include two more changes?

  1. Updating the links.json file to move the summit from Events to Programme. (We could also consider removing Tracks and Selection Process from the menu once the list of sessions is published, but that’s for another day.)
  2. Adding a redirect, similar to what Artur did here, so that both europython.eu/programme/c-api-summit and europython.eu/c-api-summit resolve. (Ege will review the redirect mapping more broadly at a later stage.)

@cmaureir
Copy link
Contributor

So I think it means if @cmaureir agrees, this PR will include two more changes?

1. Updating the [links.json file](https://github.com/EuroPython/website/blob/b0f564c6a97fa772e6d65e282434674f0c998271/src/data/links.json) to move the summit from `Events` to `Programme`. (We could also consider removing `Tracks` and `Selection Process` from the menu once the list of sessions is published, but that’s for another day.)

2. Adding a redirect, similar to what Artur did [here](https://github.com/EuroPython/website/pull/987/), so that both `europython.eu/programme/c-api-summit` and `europython.eu/c-api-summit` resolve. (Ege will review the redirect mapping more broadly at a later stage.)

This is now done. I'd appreciate a new review so we can merge this soon!

@hypha
Copy link
Contributor

hypha commented Feb 11, 2025

I am confused. The code and content all looks good. But in the preview, the URL is still https://c-api-summit.ep-preview.click/events/c-api-summit/. https://c-api-summit.ep-preview.click/programme/c-api-summit/ is 404, so the redirect also doesn't resolve. I don't know if this is a preview issue or something else is at play here. Maybe @egeakman or @artcz know why?

@artcz
Copy link
Contributor

artcz commented Feb 11, 2025

@hypha https://github.com/EuroPython/website/pull/995/files here everything looks like it's in /events/c-api so the preview looks correct
image

@hypha
Copy link
Contributor

hypha commented Feb 11, 2025

@artcz! Thanks! I completely missed that!
Edit: sorry for shouting!

Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to Artur's tip, fixed the url in a9f6872 and all looks good to me now.

@cmaureir cmaureir merged commit c5f28a5 into ep2025 Feb 11, 2025
4 checks passed
@cmaureir cmaureir deleted the c-api-summit branch February 11, 2025 11:53
@cmaureir
Copy link
Contributor

Thanks everyone for all the feedback!

@hypha hypha mentioned this pull request Feb 17, 2025
rodrigogiraoserrao added a commit that referenced this pull request Mar 3, 2025
Based off of #995 and #623.

The WASM page from last year linked to ticket info but we don't have
that page up yet, correct?

@ntoll : as agreed, I copied the info from last year. Could you please
take a look at this page/the preview and make sure everything looks
alright? 🙏

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants