Skip to content
This repository was archived by the owner on Oct 13, 2020. It is now read-only.

Conversation

@AlexDpy
Copy link
Contributor

@AlexDpy AlexDpy commented May 9, 2016

There is a bug in igorw/config-service-provider with the symfony/yaml >= 3.0.

There is a PR to fix it, it's not merged yet so we need to fix it here.
igorw/ConfigServiceProvider#46

@SelrahcD
Copy link
Contributor

SelrahcD commented May 9, 2016

Nop. Not a bug.

igorw/ConfigServiceProvider#51

@remi-san
Copy link
Contributor

remi-san commented May 9, 2016

Yes, but the version in composer is in ~2.1.

So, no need to do that in the skeleton.

Feel free to update both yaml and config in composer.json when everything is fixed though.

@remi-san remi-san closed this May 9, 2016
@AlexDpy
Copy link
Contributor Author

AlexDpy commented May 9, 2016

And what if I want to use symfony/yaml 3.0 now without waiting for this to be fixed ?

@SelrahcD
Copy link
Contributor

SelrahcD commented May 9, 2016

Does the other use of the symfony/yaml requires 3.* or is it possible to use a 2+ version ?

@AlexDpy
Copy link
Contributor Author

AlexDpy commented May 9, 2016

https://github.com/symfony/yaml/blob/2.8/Yaml.php#L36

passing a filename is deprecated since 2.2. I think passing the file_get_contents is the right way to do it anyway.

@SelrahcD
Copy link
Contributor

SelrahcD commented May 9, 2016

A lot of libs allow to use both v2 and v3. If nothing requires to upgrade to v3 we are not in trouble so far.

@remi-san
Copy link
Contributor

remi-san commented May 9, 2016

And if you really want to upgrade to yaml v3 before config is compatible, create the class you wanted to put in the skeleton in your own project.

@SelrahcD
Copy link
Contributor

SelrahcD commented May 10, 2016

Won't be possible because symfony/yaml is specified to be ~2.1 here.

Edit : My bad, because we clone the skeleton this is doable.

@AlexDpy AlexDpy deleted the allow-sf-yaml-3 branch August 24, 2016 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants