Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new package for Vesktop, a standalone Electron-based Discord client with Vencord integration and improved Linux support.
Changes:
- Creates a new package template for Vesktop version 1.6.3
- Adds launcher script with support for user-defined flags
- Includes desktop entry file for desktop environment integration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| srcpkgs/vesktop/template | Package build template defining dependencies, build steps, and installation |
| srcpkgs/vesktop/files/vesktop.sh | Launcher script that handles user configuration flags |
| srcpkgs/vesktop/files/vesktop.desktop | Desktop entry file for application menu integration |
| checksum=19f131dcfaa48df02268bbda538389c7e1ce63c80420fa617089a83253dba702 | ||
| do_extract() { | ||
| mkdir -p "${wrksrc}" | ||
| tar xf "${DISTDIR}/Vesktop-v${version}.tar.gz" --strip-components=1 -C "${wrksrc}" |
There was a problem hiding this comment.
The tar command references 'Vesktop-v${version}.tar.gz' but the distfiles URL at line 12 will download the file as 'v${version}.tar.gz'. This filename mismatch will cause extraction to fail. Update the filename in the tar command to match the actual downloaded filename: '${DISTDIR}/v${version}.tar.gz' or ensure the distfile is renamed appropriately.
| tar xf "${DISTDIR}/Vesktop-v${version}.tar.gz" --strip-components=1 -C "${wrksrc}" | |
| tar xf "${DISTDIR}/v${version}.tar.gz" --strip-components=1 -C "${wrksrc}" |
| cd "${wrksrc}" | ||
| vmkdir usr/lib/${pkgname} | ||
| vcopy "dist/linux-unpacked/*" "usr/lib/${pkgname}" | ||
| vinstall ${FILESDIR}/vesktop.desktop 644 usr/share/applications vesktop.desktop |
There was a problem hiding this comment.
The filename 'vesktop.desktop' is redundant in the vinstall command. The third argument already specifies the destination filename, so you can simplify this to: vinstall ${FILESDIR}/vesktop.desktop 644 usr/share/applications
| vinstall ${FILESDIR}/vesktop.desktop 644 usr/share/applications vesktop.desktop | |
| vinstall ${FILESDIR}/vesktop.desktop 644 usr/share/applications |
No description provided.