Skip to content

refactor(arrow-rs): migrate multi-key sort comparator to Arrow-rs #6087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
huleilei wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Draft

refactor(arrow-rs): migrate multi-key sort comparator to Arrow-rs #6087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/daft-core/src/array/ops/sort.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,19 @@ pub fn build_multi_array_bicompare(
.zip(descending.iter())
.zip(nulls_first.iter())
{
// Use the Arrow-rs export path to obtain canonical Arrow arrays,
// then bridge them into the legacy arrow2-based comparator builder.
let l_arrow = l.to_arrow()?;
let r_arrow = r.to_arrow()?;

#[allow(deprecated, reason = "arrow2 migration")]
let l_arrow2: Box<dyn daft_arrow::array::Array> = Box::from(l_arrow.as_ref() as &dyn Array);
#[allow(deprecated, reason = "arrow2 migration")]
let r_arrow2: Box<dyn daft_arrow::array::Array> = Box::from(r_arrow.as_ref() as &dyn Array);

cmp_list.push(build_nulls_first_compare_with_nulls(
l.to_arrow2().as_ref(),
r.to_arrow2().as_ref(),
l_arrow2.as_ref(),
r_arrow2.as_ref(),
*desc,
*nf,
)?);
Expand Down
Loading