-
Notifications
You must be signed in to change notification settings - Fork 98
Implement map-specific postcard textures #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Implement map-specific postcard textures #1056
Conversation
|
It seems that GH and Azure can't agree on the commit hash. I'll push an empty commit. |
|
That jogged it just right, the TAS check is running. |
Wartori54
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Together with allowing text color to be changed it would be nice to also add text repositioning in that upcoming PR for a more complete feature.
|
Will create an issue and assign myself to it to not forget. |
|
The pull request was approved and entered the 3-day last-call window. |
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
|
This will need a slight change in the |
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
Closes #1043. Allows mappers to specify the texture of the postcard in the map's
.meta.yaml, like so:If the texture does not exist, the
__fallbacktexture will be displayed. Because the fallback texture is so small, most of the text will be cut off by it.I suppose a next PR could let mappers change the color of the savedata name text that's rendered on the postcard to allow dark postcards?