Skip to content

Comments

logs the total of loaded modules at launch#884

Merged
Wartori54 merged 6 commits intoEverestAPI:devfrom
AAA1459:modcount
Jun 14, 2025
Merged

logs the total of loaded modules at launch#884
Wartori54 merged 6 commits intoEverestAPI:devfrom
AAA1459:modcount

Conversation

@AAA1459
Copy link
Contributor

@AAA1459 AAA1459 commented Feb 27, 2025

No description provided.

@maddie480 maddie480 added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label May 18, 2025
@Wartori54
Copy link
Member

Wartori54 commented Jun 2, 2025

Could be merged with the following log, or otherwise the second "loader" capitalized.

@Wartori54
Copy link
Member

Wartori54 commented Jun 3, 2025

I meant the "loaded" in the second line, so that the sentence is capitalized, sorry.
Like Logger.Info("loader", $"Loaded {Everest._Modules.Count} modules");

You also seem to have converted all line endings from LF to CRLF accidentally.

@AAA1459
Copy link
Contributor Author

AAA1459 commented Jun 4, 2025 •
edited
Loading

You also seem to have converted all line endings from LF to CRLF accidentally.

hmm don't know why that happened, got rip of it.

does you mean like this now?

Wartori54
Wartori54 approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@Wartori54 Wartori54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The line 1 change is due to the BOM characters being removed, but that's fine since there is no consistent pattern in Everest anyway.

@maddie480 maddie480 added the 4: should be squashed PR with a messy commit history that should be squash merged label Jun 10, 2025
@maddie480-bot
Copy link
Member

maddie480-bot commented Jun 10, 2025

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Jun 15, 2025, 12:00 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jun 10, 2025
@maddie480-bot
Copy link
Member

maddie480-bot commented Jun 14, 2025

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Jun 14, 2025
@Wartori54 Wartori54 merged commit 2edd40b into EverestAPI:dev Jun 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maddie480 maddie480 maddie480 approved these changes

@Wartori54 Wartori54 Wartori54 approved these changes

Assignees

No one assigned

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed) 4: should be squashed PR with a messy commit history that should be squash merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AAA1459 @Wartori54 @maddie480-bot @maddie480