Conversation
maddie480
left a comment
There was a problem hiding this comment.
needs updating with the lib-ext rework (though I see a PR is underway to do it already 😅)
e939450 to
f26c9ee
Compare
|
Conflicts solved, bumped lib-ext to include the conflicting change (adding |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
06717d7 to
68bfc11
Compare
There was a problem hiding this comment.
seems like Everest is failing to install? 😅
System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at MonoMod.Cil.ILCursor.GotoNext(MoveType moveType, Func`2[] predicates) in /home/vsts/work/1/s/external/MonoMod/src/MonoMod.Utils/Cil/ILCursor.cs:line 308
at MonoMod.Cil.ILCursor.GotoNext(Func`2[] predicates) in /home/vsts/work/1/s/external/MonoMod/src/MonoMod.Utils/Cil/ILCursor.cs:line 393
at MonoMod.MonoModRules.PatchEngineCctor(ILContext context, CustomAttribute attrib)
|
Are you installing the version on the SDL3 beta? |
|
no, the install seems to be crashing on 1.4.0.0 (see TAS check pipeline), this needs to be fixed if we don't want to wait for 1.4.1.0 to become default (if this happens) to merge this |
|
Fixed. Patching the steam sdl3/1.4.1.0 version on my end works as well. Note that the .net 8 upgrade also added a print statement to log the exact runtime version, thus on 1.4.1.0 there is some redundancy (both vanilla and Everest show that information). I have not removed it (even tho removing it is trivial) since I find it useful to have all system information in one big block right after the "Booting Everest" log, and the redundancy is not even visible if you are not looking for it specifically. |
|
The pull request was approved and entered the 3-day last-call window. |
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
Introduces the required changes in Everest to support the publicly available version of Celeste 1.4.1.0. Of course this version may not be final, but all changes have been confirmed by the devs so the fixes are final for sure.
This also forces a downgrade to sdl2, if required. This is the reason the
libfmod_SDL.solibrary has to be bundled for linux as well.