Skip to content

Comments

Celeste 1.4.1.0 support#887

Merged
Wartori54 merged 4 commits intoEverestAPI:devfrom
Wartori54:1.4.1.0-support
Jul 15, 2025
Merged

Celeste 1.4.1.0 support#887
Wartori54 merged 4 commits intoEverestAPI:devfrom
Wartori54:1.4.1.0-support

Conversation

@Wartori54
Copy link
Member

Introduces the required changes in Everest to support the publicly available version of Celeste 1.4.1.0. Of course this version may not be final, but all changes have been confirmed by the devs so the fixes are final for sure.

This also forces a downgrade to sdl2, if required. This is the reason the libfmod_SDL.so library has to be bundled for linux as well.

@maddie480 maddie480 added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label May 18, 2025
Copy link
Member

@maddie480 maddie480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs updating with the lib-ext rework (though I see a PR is underway to do it already 😅)

@maddie480-bot maddie480-bot added 2: changes requested This PR cannot be merged because changes were requested (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jun 7, 2025
@Wartori54
Copy link
Member Author

Conflicts solved, bumped lib-ext to include the conflicting change (adding libfmod_SDL.so in lib64-linux) in there.

@Wartori54 Wartori54 requested a review from maddie480 June 12, 2025 11:48
@maddie480 maddie480 dismissed their stale review June 16, 2025 08:00

feedback resolved

@maddie480

This comment was marked as outdated.

@maddie480

This comment was marked as outdated.

@maddie480-bot maddie480-bot added 1: review needed This PR needs 2 approvals to be merged (bot-managed) and removed 2: changes requested This PR cannot be merged because changes were requested (bot-managed) labels Jun 16, 2025
Copy link
Member

@maddie480 maddie480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like Everest is failing to install? 😅

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
  at MonoMod.Cil.ILCursor.GotoNext(MoveType moveType, Func`2[] predicates) in /home/vsts/work/1/s/external/MonoMod/src/MonoMod.Utils/Cil/ILCursor.cs:line 308
  at MonoMod.Cil.ILCursor.GotoNext(Func`2[] predicates) in /home/vsts/work/1/s/external/MonoMod/src/MonoMod.Utils/Cil/ILCursor.cs:line 393
  at MonoMod.MonoModRules.PatchEngineCctor(ILContext context, CustomAttribute attrib)

@SnipUndercover
Copy link
Member

Are you installing the version on the SDL3 beta?

@maddie480
Copy link
Member

no, the install seems to be crashing on 1.4.0.0 (see TAS check pipeline), this needs to be fixed if we don't want to wait for 1.4.1.0 to become default (if this happens) to merge this

@maddie480-bot maddie480-bot added 2: changes requested This PR cannot be merged because changes were requested (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jun 16, 2025
@Wartori54
Copy link
Member Author

Fixed. Patching the steam sdl3/1.4.1.0 version on my end works as well.

Note that the .net 8 upgrade also added a print statement to log the exact runtime version, thus on 1.4.1.0 there is some redundancy (both vanilla and Everest show that information). I have not removed it (even tho removing it is trivial) since I find it useful to have all system information in one big block right after the "Booting Everest" log, and the redundancy is not even visible if you are not looking for it specifically.
A very similar redundancy has been present for a long while too with "CELESTE: 1.4.0.0" and the VersionCelesteString log.

@Wartori54 Wartori54 requested a review from maddie480 June 23, 2025 21:55
@maddie480-bot maddie480-bot added 1: review needed This PR needs 2 approvals to be merged (bot-managed) and removed 2: changes requested This PR cannot be merged because changes were requested (bot-managed) labels Jun 23, 2025
@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Jul 13, 2025, 12:00 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jul 7, 2025
@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Jul 12, 2025
@Wartori54 Wartori54 merged commit 6b3f653 into EverestAPI:dev Jul 15, 2025
3 checks passed
@Wartori54 Wartori54 mentioned this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants