Fix hardlock when leaving OuiMapSearch#926
Merged
Wartori54 merged 1 commit intoEverestAPI:devfrom Jul 13, 2025
Merged
Conversation
maddie480-bot
added
the
1: review needed
Wartori54
approved these changes
Jun 23, 2025
Member
Wartori54
left a comment
Wartori54
left a comment
There was a problem hiding this comment.
I would not be surprised if there are some other bugs relating to the text input since those are quite messy in Celeste, but this LGTM.
microlith57
approved these changes
Jul 7, 2025
Member
|
The pull request was approved and entered the 3-day last-call window. |
maddie480-bot
added
3: last call window
Member
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
maddie480-bot
added
4: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The game still processes inputs in the
OnTextInputhandler when leaving theOuiMapSearch.This can cause a "hardlock" (game not processing any input), because the handler can disable the input engine.
The "hardlock" can be reproduced by entering some input when transitioning from the
OuiMapSearchto theOuiChapterSelect.This PR prevents the "hardlock" by removing the handler (which is done by setting
Searchingtofalse) right at the start of theLeavemethod, instead of waiting for the transition to end.(originally reported by
tobyaaaon Discord)