Animated Chapter Select Icons#927
Conversation
maddie480-bot
added
the
1: review needed
maddie480-bot
added
2: changes requested
Now allows for front and back sprites to be animated independently; and no longer requires a unique string in the file path anymore. (Also streamlined the yaml parsing.)
|
All requested changes have been made, (Perhaps I may want to add an |
JaThePlayer
left a comment
JaThePlayer
left a comment
There was a problem hiding this comment.
lgtm, switching over to generated regex for slightly better perf would be nice but its not the end of the world here.
| #pragma warning disable CS0649 // Field is never assigned to, and will always have its default value | ||
| #pragma warning disable CS0626 // Method, operator, or accessor is marked external and has no attributes on it | ||
| #pragma warning disable CS8632 // The annotation for nullable reference types should only be used in code within a #nullable annotations context | ||
| #pragma warning disable SYSLIB1045 // Use GeneratedRegexAttribute to generate the regular expression implementation at compile time. |
There was a problem hiding this comment.
Well, we should be doing that
maddie480-bot
added
1: review needed
Minor changes suggested by Wartori; including clarification on the `SaveData.Instance == null` check
|
The pull request was approved and entered the 3-day last-call window. |
maddie480-bot
added
3: last call window
|
The pull request was approved and entered the 3-day last-call window. |
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
maddie480-bot
added
4: ready to merge
5 participants
This PR allows for chapter icons (
OuiChapterSelectIcon) to be animated;The system for this is similar to that of Animated Parallax, using a .meta.yaml file to provide extra data if needed.
More detail on usage can be found on my (presumably now temporary) gamebanana page for AnimatedMapIconLib.
Changes include:
OuiChapterSelectIcon's ctor to allow for the detection of animated icons, this is done by checking if the path to the icon cotains the keyword"AnimatedMapIcons"; e.g.Graphics\Atlases\Gui\areas\MyCoolMod\AnimatedMapIconsOuiChapterSelectIcon.Updateto allow for updating both the front and back textures with the supplied animated textures.Please feel free to inform me of any alternative implementation, or any incorrect practices, and or make any adjustments.