Make OnEndOfFrame thread safe#928
Merged
maddie480 merged 1 commit intoEverestAPI:devfrom Jun 30, 2025
Merged
Conversation
maddie480-bot
added
the
1: review needed
JaThePlayer
approved these changes
Jun 20, 2025
Member
JaThePlayer
left a comment
JaThePlayer
left a comment
There was a problem hiding this comment.
I wouldn't really say it's about thread-safety as its more about being able to set OnEndOfFrame on the same thread, but I'm for this either way. (With that said, Interlocked here isn't really necessary, but the code's cleaner than the non-Interlocked way, so it's fine imo)
Contributor
Author
|
It's initially for thread safety, but the listed changes are more significant. |
Wartori54
approved these changes
Jun 23, 2025
Member
|
The pull request was approved and entered the 3-day last-call window. |
maddie480-bot
added
3: last call window
Member
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
maddie480-bot
added
4: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: Any
OnEndOfFrameadded duringOnEndOfFrameinvocation will be discarded.Changes: They will be invoked in next frame.
Note:
OnEndOfFramecan add newOnEndOfFrames. Nobody should be doing this (otherwise they will notice it), but if it happens, this pr causes desync.