Adjusted Logic Config File #111
Conversation
WalkthroughThe changes refactor configuration management by removing Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant SettingsConfig.cs
participant UserProfileConfig
Workflow->>SettingsConfig.cs: Replace '0.0.0' with FULL_VERSION
Workflow->>SettingsConfig.cs: Replace 'PlaceHolderApiKey' with secret API key
SettingsConfig.cs->>UserProfileConfig: Ensure config file exists (static constructor)
SettingsConfig.cs->>UserProfileConfig: Update version/API key in config file
UserProfileConfig-->>SettingsConfig.cs: Confirm update
Possibly related PRs
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (3)
.github/workflows/dev_actions.yml (1)
72-72: Remove trailing spaces- (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs + (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs.github/workflows/dev_pull_request.yml (1)
70-70: Remove trailing spaces- (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs + (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs.github/workflows/production_actions.yml (1)
101-101: Remove empty line with trailing spacesRemove the empty line at line 101 that contains trailing spaces.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.github/workflows/dev_actions.yml(1 hunks).github/workflows/dev_pull_request.yml(1 hunks).github/workflows/production_actions.yml(1 hunks)Common_glTF_Exporter/App.config(0 hunks)Common_glTF_Exporter/Common_glTF_Exporter.projitems(0 hunks)Common_glTF_Exporter/Utils/SettingsConfig.cs(1 hunks)GltfInstaller/Program.cs(1 hunks)
💤 Files with no reviewable changes (2)
- Common_glTF_Exporter/Common_glTF_Exporter.projitems
- Common_glTF_Exporter/App.config
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/dev_actions.yml
[error] 72-72: trailing spaces
(trailing-spaces)
.github/workflows/production_actions.yml
[error] 97-97: trailing spaces
(trailing-spaces)
.github/workflows/dev_pull_request.yml
[error] 70-70: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (1)
GltfInstaller/Program.cs (1)
28-117: Clean removal of configuration files from installerThe removal of
.dll.configfiles from the installer is consistent with the migration to the newSettingsConfigapproach. The formatting improvements also enhance readability.
.github/workflows/dev_actions.yml
Outdated
| - name: Setting new version to the config file | ||
| run: | | ||
| (Get-Content Common_glTF_Exporter/App.config) -replace 'key="version" value="[^"]+"', "key=`"version`" value=`"$env:FULL_VERSION`"" | Out-File -encoding ASCII Common_glTF_Exporter/App.config | ||
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | ||
| - name: Configuring Key | ||
| run: | | ||
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', ${{ secrets.EVERSE_GLTF_EXPORTER_APIKEY }} | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Verify string replacement operations succeed
The string replacement approach could fail silently if the placeholder strings change in the source code.
Add verification to ensure the replacements actually occurred:
- name: Setting new version to the config file
run: |
(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs
+ if (!(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern $env:FULL_VERSION -Quiet)) {
+ throw "Version replacement failed"
+ }
- name: Configuring Key
run: |
(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', ${{ secrets.EVERSE_GLTF_EXPORTER_APIKEY }} | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs
+ if (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern 'PlaceHolderApiKey' -Quiet) {
+ throw "API key replacement failed"
+ }🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 72-72: trailing spaces
(trailing-spaces)
🤖 Prompt for AI Agents
In .github/workflows/dev_actions.yml around lines 69 to 75, the current string
replacement commands do not verify if the replacements succeeded, which could
lead to silent failures if the placeholders change. Modify the script to check
the content before and after replacement to confirm that the target strings were
found and replaced. If the replacement did not occur, fail the step or output an
error message to ensure the issue is caught early.
| - name: Setting new version to the config file | ||
| run: | | ||
| (Get-Content Common_glTF_Exporter/App.config) -replace 'key="version" value="[^"]+"', "key=`"version`" value=`"$env:FULL_VERSION`"" | Out-File -encoding ASCII Common_glTF_Exporter/App.config | ||
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | ||
| - name: Configuring Key | ||
| run: | | ||
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', ${{ secrets.EVERSE_GLTF_EXPORTER_APIKEY }} | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Verify string replacement operations succeed
The string replacement approach could fail silently if the placeholder strings change in the source code.
Add verification to ensure the replacements actually occurred:
- name: Setting new version to the config file
run: |
(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs
+ if (!(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern $env:FULL_VERSION -Quiet)) {
+ throw "Version replacement failed"
+ }
- name: Configuring Key
run: |
(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', ${{ secrets.EVERSE_GLTF_EXPORTER_APIKEY }} | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs
+ if (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern 'PlaceHolderApiKey' -Quiet) {
+ throw "API key replacement failed"
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Setting new version to the config file | |
| run: | | |
| (Get-Content Common_glTF_Exporter/App.config) -replace 'key="version" value="[^"]+"', "key=`"version`" value=`"$env:FULL_VERSION`"" | Out-File -encoding ASCII Common_glTF_Exporter/App.config | |
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | |
| - name: Configuring Key | |
| run: | | |
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', ${{ secrets.EVERSE_GLTF_EXPORTER_APIKEY }} | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | |
| - name: Setting new version to the config file | |
| run: | | |
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | |
| if (!(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern $env:FULL_VERSION -Quiet)) { | |
| throw "Version replacement failed" | |
| } | |
| - name: Configuring Key | |
| run: | | |
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', ${{ secrets.EVERSE_GLTF_EXPORTER_APIKEY }} | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | |
| if (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern 'PlaceHolderApiKey' -Quiet) { | |
| throw "API key replacement failed" | |
| } |
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 70-70: trailing spaces
(trailing-spaces)
🤖 Prompt for AI Agents
In .github/workflows/dev_pull_request.yml around lines 67 to 73, the string
replacement commands for updating version and API key in SettingsConfig.cs may
fail silently if the placeholders are missing. Modify the script to verify that
the replacements actually occurred by checking the output content for the
expected changes after each replacement. If the replacement did not happen, fail
the step or log an error to ensure the issue is caught early.
| - name: Setting new version to the config file | ||
| run: | | ||
| (Get-Content Common_glTF_Exporter/App.config) -replace 'key="version" value="[^"]+"', "key=`"version`" value=`"$env:FULL_VERSION`"" | Out-File -encoding ASCII Common_glTF_Exporter/App.config | ||
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | ||
| - name: Configuring Key | ||
| run: | | ||
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', ${{ secrets.EVERSE_GLTF_EXPORTER_APIKEY }} | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Verify string replacement operations succeed in production workflow
The string replacement approach could fail silently if the placeholder strings change. This is especially critical for the production workflow.
Add verification to ensure the replacements actually occurred:
- name: Setting new version to the config file
run: |
(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs
+ if (!(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern $env:FULL_VERSION -Quiet)) {
+ throw "Version replacement failed"
+ }
- name: Configuring Key
run: |
(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', ${{ secrets.EVERSE_GLTF_EXPORTER_APIKEY }} | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs
+ if (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern 'PlaceHolderApiKey' -Quiet) {
+ throw "API key replacement failed"
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Setting new version to the config file | |
| run: | | |
| (Get-Content Common_glTF_Exporter/App.config) -replace 'key="version" value="[^"]+"', "key=`"version`" value=`"$env:FULL_VERSION`"" | Out-File -encoding ASCII Common_glTF_Exporter/App.config | |
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | |
| - name: Configuring Key | |
| run: | | |
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', ${{ secrets.EVERSE_GLTF_EXPORTER_APIKEY }} | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | |
| - name: Setting new version to the config file | |
| run: | | |
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | |
| if (!(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern $env:FULL_VERSION -Quiet)) { | |
| throw "Version replacement failed" | |
| } | |
| - name: Configuring Key | |
| run: | | |
| (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', ${{ secrets.EVERSE_GLTF_EXPORTER_APIKEY }} | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs | |
| if (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern 'PlaceHolderApiKey' -Quiet) { | |
| throw "API key replacement failed" | |
| } |
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 97-97: trailing spaces
(trailing-spaces)
🤖 Prompt for AI Agents
In .github/workflows/production_actions.yml around lines 94 to 100, the current
string replacement commands do not verify if the replacements succeeded, risking
silent failures if placeholders change. Modify the workflow to check the output
after each replacement to confirm the placeholder strings were found and
replaced. If a replacement does not occur, the workflow should fail or log an
error to prevent silent issues in production.
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (3)
.github/workflows/dev_pull_request.yml (1)
67-70: Replacement step still lacks verificationPrevious feedback requested an assertion that the
'0.0.0'token was actually replaced (to avoid silent failures). The step remains unchanged..github/workflows/dev_actions.yml (1)
69-72: No check that version string was replaced — identical concern already raised..github/workflows/production_actions.yml (1)
94-97: Still no post-replacement validation — prior comment not addressed.
🧹 Nitpick comments (3)
.github/workflows/dev_pull_request.yml (1)
70-70: Trim trailing whitespace – caught by YAML-lint..github/workflows/dev_actions.yml (1)
72-72: Trailing spaces flagged by YAML-lint..github/workflows/production_actions.yml (1)
97-97: Remove trailing whitespace to satisfy YAML-lint.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/dev_actions.yml(1 hunks).github/workflows/dev_pull_request.yml(1 hunks).github/workflows/production_actions.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/dev_actions.yml
[error] 72-72: trailing spaces
(trailing-spaces)
.github/workflows/dev_pull_request.yml
[error] 70-70: trailing spaces
(trailing-spaces)
.github/workflows/production_actions.yml
[error] 97-97: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (6)
.github/workflows/dev_pull_request.yml (2)
73-75: Missing$prevents API-key substitution – still unresolved
The variableapiUrlKeyis passed as a literal string; PowerShell needs$apiUrlKey. The placeholder will never be replaced, breaking authentication at runtime.- (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', apiUrlKey | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs + (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', $apiUrlKey | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.csTagging again because the same issue was highlighted in an earlier review but is still present.
67-70: Guard the replace-step with an assertion
If'0.0.0'disappears fromSettingsConfig.cs, the replacement silently does nothing. Fail fast to avoid shipping a wrong version:(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs +if (!(Select-String -Path Common_glTF_Exporter/Utils/SettingsConfig.cs -Pattern $env:FULL_VERSION -Quiet)) { + throw "Version replacement failed" +}.github/workflows/production_actions.yml (2)
100-102: API-key still not injected –$sigil missingSame defect as in dev workflow; the key never reaches
SettingsConfig.cs.- (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', apiUrlKey | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs + (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', $apiUrlKey | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs
94-97: Add post-replace verification for version string – identical rationale as dev workflow..github/workflows/dev_actions.yml (2)
75-76: API-key placeholder not replaced – variable expansion is missing:- (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', apiUrlKey | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs + (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', $apiUrlKey | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs
69-72: Replicate the version-replacement guard here to detect silent failures.
🧹 Nitpick comments (3)
.github/workflows/dev_pull_request.yml (1)
69-70: Trim trailing whitespace – YAMLlint is red-flagging lines 70 & 76
Remove the extra spaces to keep the workflow YAML-lint clean.Also applies to: 75-75
.github/workflows/production_actions.yml (1)
97-97: Trailing whitespace reported by YAMLlint – please strip.Also applies to: 103-103
.github/workflows/dev_actions.yml (1)
71-71: Remove trailing spaces (lines 72 & 78 per YAMLlint).Also applies to: 77-77
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/dev_actions.yml(1 hunks).github/workflows/dev_pull_request.yml(1 hunks).github/workflows/production_actions.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/dev_actions.yml
[error] 72-72: trailing spaces
(trailing-spaces)
[error] 78-78: trailing spaces
(trailing-spaces)
.github/workflows/dev_pull_request.yml
[error] 70-70: trailing spaces
(trailing-spaces)
[error] 76-76: trailing spaces
(trailing-spaces)
.github/workflows/production_actions.yml
[error] 97-97: trailing spaces
(trailing-spaces)
[error] 103-103: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (6)
.github/workflows/dev_pull_request.yml (2)
67-70: Still no verification that the version string was actually replaced
Past reviews already highlighted that the script may succeed even when'0.0.0'is absent. Please fail fast by asserting the replacement occurred.(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace '0.0.0', $env:FULL_VERSION | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs +if (!(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern $env:FULL_VERSION -Quiet)) { + throw "Version replacement failed" +}
71-75: Same silent-failure risk for the API-key replacementAdd a post-replacement check to guarantee the placeholder is gone, mirroring the approach above.
(Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs) -replace 'PlaceHolderApiKey', $apiUrlKey | Out-File -encoding ASCII Common_glTF_Exporter/Utils/SettingsConfig.cs +if (Get-Content Common_glTF_Exporter/Utils/SettingsConfig.cs | Select-String -Pattern 'PlaceHolderApiKey' -Quiet) { + throw "API key replacement failed" +}.github/workflows/production_actions.yml (2)
94-97: Replacement verification still missing (production)Production builds should be at least as strict as dev. Fail the job when the version token isn’t found.
98-102: Add check that the API key placeholder was removedSame recommendation as dev workflow; avoid silently shipping a build with an empty API key.
.github/workflows/dev_actions.yml (2)
69-72: Guard the version substitution with an assertionReplicate the quick sanity check pattern to ensure the version string is present after replacement.
73-77: Assert API-key placeholder removalPrevent unnoticed failures by verifying
PlaceHolderApiKeyis no longer present.
🧹 Nitpick comments (3)
.github/workflows/dev_pull_request.yml (1)
70-70: Remove trailing space – YAML-lint error
Line 70 has trailing whitespace flagged by the linter. Delete it to keep the workflow lint-clean..github/workflows/production_actions.yml (1)
97-97: Trailing whitespace triggers YAML-lint
Strip the extra space on line 97..github/workflows/dev_actions.yml (1)
72-72: Trailing space detected
Remove the trailing whitespace on line 72 to satisfy YAML-lint.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/dev_actions.yml(1 hunks).github/workflows/dev_pull_request.yml(1 hunks).github/workflows/production_actions.yml(1 hunks)Common_glTF_Exporter/Utils/SettingsConfig.cs(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- Common_glTF_Exporter/Utils/SettingsConfig.cs
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/dev_actions.yml
[error] 72-72: trailing spaces
(trailing-spaces)
.github/workflows/dev_pull_request.yml
[error] 70-70: trailing spaces
(trailing-spaces)
.github/workflows/production_actions.yml
[error] 97-97: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
Summary by CodeRabbit