Skip to content

Comments

Develop#124

Merged
vnoves merged 4 commits intomasterfrom
develop
Sep 15, 2025
Merged

Develop#124
vnoves merged 4 commits intomasterfrom
develop

Conversation

@vnoves
Copy link
Member

@vnoves vnoves commented Sep 15, 2025

Summary by CodeRabbit

  • New Features

    • Added compatibility with Revit 2026.
  • Bug Fixes

    • Updated Contextual Help link to the correct website.
    • Improved handling of element hide/lock conditions during export to better respect view settings.
  • Chores

    • Reduced installer size by removing unnecessary PNG assets.
    • Standardized build output paths for 2025/2026 projects for more predictable artifacts.

@vnoves vnoves merged commit bc9cb5d into master Sep 15, 2025
0 of 3 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Sep 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates contextual help URL sourcing, adjusts utility logic for element visibility checks, adds 2026 packaging/support, trims installer asset patterns, and standardizes build output paths for 2025/2026 projects. No public API changes; primarily configuration, resource, and a targeted logic rework.

Changes

Cohort / File(s) Summary
Add-in startup and help URL
Common_glTF_Exporter/ExternalApplication.cs
Replaces hard-coded LEIAURL with Links.leiaWebsite in contextual help; reorganizes using directives and introduces a RibbonPanel alias.
Packaging and installer
Common_glTF_Exporter/PackageContents.xml, GltfInstaller/Program.cs
Adds 2026 part with runtime requirements and component entry; removes per-year PNG asset patterns from installer; minor path literal tweak for 2022 DLL; no control-flow changes.
Utility visibility/lock logic
Common_glTF_Exporter/Utils/Util.cs
Refactors CanBeLockOrHidden: prioritizes element.CanBeHidden(view) early; broadens non-RFA check to `Category.CanAddSubcategory
Build output configuration
Revit_glTF_Exporter_2025/Revit_glTF_Exporter_2025.csproj, Revit_glTF_Exporter_2026/Revit_glTF_Exporter_2026.csproj
Sets OutputPath=bin\$(Configuration)\ and disables appending TFM/RID to output path; aligns post-build sign path usage (2026). Per-config outputs remain effective.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Caller
  participant Util
  participant Element
  participant View
  participant Category

  Caller->>Util: CanBeLockOrHidden(element, view, rfaFile)
  Util->>Element: CanBeHidden(view)?
  alt Can be hidden
    Util-->>Caller: true
  else Not hidden
    Util->>Element: Category
    Util->>Category: CanAddSubcategory or AllowsBoundParameters?
    alt Non-RFA and category allows
      Util-->>Caller: true
    else Otherwise
      Util-->>Caller: false
    end
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

A bunny taps keys in a twilight glow,
Swaps hard-coded links for the ones we know.
Trims PNGs from installer’s pack,
Adds twenty‑twenty‑six to the winding track.
With outputs neat and logic keen—
Hop! Another build, crisp and clean. 🥕✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f6e2552 and 0d9c2e6.

📒 Files selected for processing (6)
  • Common_glTF_Exporter/ExternalApplication.cs (2 hunks)
  • Common_glTF_Exporter/PackageContents.xml (2 hunks)
  • Common_glTF_Exporter/Utils/Util.cs (1 hunks)
  • GltfInstaller/Program.cs (1 hunks)
  • Revit_glTF_Exporter_2025/Revit_glTF_Exporter_2025.csproj (1 hunks)
  • Revit_glTF_Exporter_2026/Revit_glTF_Exporter_2026.csproj (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant