-
Notifications
You must be signed in to change notification settings - Fork 114
Fix debug adapter reconnection after disconnect #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Clear debugger reference in DebugeeProcess after disconnect to allow reconnection - Recreate TcpListener for each debug session to support multiple attach/detach cycles - Properly dispose listener in session cleanup Co-authored-by: nixel2007 <[email protected]>
Co-authored-by: nixel2007 <[email protected]>
Co-authored-by: nixel2007 <[email protected]>
I've reviewed PR #1594's development history. The current changes build on that work by fixing the TcpListener lifecycle issue - the listener is now recreated per session in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
|
@copilot посмотри комментарии от @Bayselonarrend |
|
@EvilBeaver добавь в правила фаерволла копилота адрес api.github.com, пожалуйста |
I've reviewed @Bayselonarrend's feedback from PR #1594. The main concern was about processes not terminating and the need to dispose/recreate the DebugController. That was addressed in PR #1594 with the My current changes (commit d0e6909) build on that work by fixing the TcpListener lifecycle - recreating it per session instead of once in the constructor. This ensures the listener is fresh for each reconnection, which is necessary because |
|
@copilot пользователь @Bayselonarrend проверил твою последнюю сборку, и она не работает. И его фидбэк как раз на твою версию. |
Could you provide more details on what's not working? My changes recreate the TcpListener per session (in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Добавил |
|

0 New Issues
1 Fixed Issue
0 Accepted Issues
No data about coverage (0.00% Estimated after merge)
After disconnecting from a debug session (without terminating the oscript process), subsequent attach attempts fail because the debug server stops accepting connections on the TCP port.
Changes
Client-side (
DebugeeProcess.cs)_debuggerreference after disconnect to prevent stale client reuseServer-side (
ReconnectableDebugController.cs)TcpListenerper session instead of once in constructorDelayedConnectionChannelstops the listener after first connection, so each new session needs its own listener instanceDisposeSession()instead ofDispose()Impact
Enables multiple attach/detach cycles without restarting the oscript process, as originally intended by the
ReconnectableDebugControllerdesign.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.