refactor: modularize runner codebase (Issue #6) #13
Conversation
|
Hey @nimaldanyathk! Thank you for opening a pull request. Make sure to tag the maintainers and link the issue you are solving in your pull-request description if you have not already and they'll review as soon as possible. |
|
Can you attach testing details by actually running the entire setup with the runner image from here? |
|
Sorry for the late reply I have verified the refactor by running the full Docker stack locally. steps done Started operations services (MinIO, Redis, CockroachDB). |
|
let me test by executing a run in the runner from the evoc ui |
| import threading | ||
| import subprocess | ||
| from app.config import REDIS_URL | ||
| from app.streaming import stream_reader, redis_stream_adder |
| import os | ||
| import threading | ||
| import subprocess | ||
| from app.config import REDIS_URL |
| from app.config import REDIS_URL | ||
| from app.streaming import stream_reader, redis_stream_adder | ||
|
|
||
| def run_subprocess(run_id, local_file_path, file_parent_dir, run_type, log_queue, redis_adder_thread): |
There was a problem hiding this comment.
can we log the run_id as its not being used and just for the sake of using it?
| import time | ||
| import queue | ||
| import redis | ||
| import threading |
| @@ -1,5 +1,5 @@ | |||
| minio | |||
| psycopg2 | |||
| psycopg2-binary | |||
|
/bounty 70 @nimaldanyathk |
3 participants
Resolves #6. Refactors into a modular package containing separate modules for configuration, storage, database, streaming, execution, and orchestration.
@Ashrockzzz2003