Smart integration: fix parallel object class discovery coordination#590
Open
johnstone3 wants to merge 1 commit intomasterfrom
Open
Smart integration: fix parallel object class discovery coordination#590johnstone3 wants to merge 1 commit intomasterfrom
johnstone3 wants to merge 1 commit intomasterfrom
Conversation
Add waitForSiblingByPolling() so that parallel discovery tasks always finish together - the task that completes first signals its own SUCCESS via activity resultStatus and waits for siblings; on sibling failure it returns FATAL_ERROR, on sibling success it returns success. Refactor suspendSiblings() and waitForSiblingByPolling() to use getSiblingActivityTypes() defined per handler instead of passing the set as a parameter. Fix Javadoc to correctly state SystemException is thrown when task is asked to stop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add waitForSiblingByPolling() so that parallel discovery tasks always finish together - the task that completes first signals its own SUCCESS via activity resultStatus and waits for siblings; on sibling failure it returns FATAL_ERROR, on sibling success it returns success. Refactor suspendSiblings() and waitForSiblingByPolling() to use getSiblingActivityTypes() defined per handler instead of passing the set as a parameter. Fix Javadoc to correctly state SystemException is thrown when task is asked to stop.