fix(tests): 🐛 Bind server to IPv4 and update connection logic

[PrzemyslawKlys]

• Explicitly bind the server to 127.0.0.1 to avoid macOS IPv6-only listener issues.
• Update socket connection to use localhost for better IPv4/IPv6 resolution.
• Adjust URI to match the server bind address for consistency.

[claude]

Claude finished @PrzemyslawKlys's task —— View job

---

PR Code Review

Reviewing the pull request changes for code quality, potential issues, and best practices.

Todo List:

• Read and analyze the modified test file
• Review code quality and best practices
• Check for potential bugs or issues
• Assess performance considerations
• Evaluate security concerns
• Review test coverage adequacy
• Provide comprehensive feedback

---

Code Review Feedback

✅ Overall Assessment: Good Fix

This PR addresses a legitimate cross-platform compatibility issue with IPv6/IPv4 binding on macOS. The changes are well-targeted and appropriate.

Code Quality & Best Practices

Strengths:

• Clear documentation: Excellent inline comments explaining the rationale for each change (Tests/Save-HTMLAttachment.Streaming.Tests.ps1:3, Tests/Save-HTMLAttachment.Streaming.Tests.ps1:10, Tests/Save-HTMLAttachment.Streaming.Tests.ps1:22)
• Consistent approach: All three changes work together cohesively to solve the IPv6/IPv4 binding issue
• Minimal impact: Changes are surgical and don't affect the core test logic

Minor suggestions:

• The comment style is consistent with PowerShell conventions ✓

Potential Issues

None identified - The changes are solid:

• ✅ Server binding: Explicitly binding to 127.0.0.1 prevents IPv6-only listener issues on macOS
• ✅ Connection logic: Using localhost for the socket connection allows the OS to choose the appropriate protocol
• ✅ URI consistency: Using 127.0.0.1 in the final URI matches the server bind address

Why the approach works:

1. Line 4: --bind 127.0.0.1 forces the Python HTTP server to IPv4
2. Line 11: localhost in socket connection allows OS-level resolution flexibility
3. Line 23: 127.0.0.1 in URI ensures consistency with the bound server address

Performance Considerations

✅ No performance impact: The changes maintain the same network connectivity patterns with no additional overhead.

Security Concerns

✅ No security issues:

• Still binding to localhost/loopback addresses only
• No exposure to external networks
• Test isolation maintained

Test Coverage

✅ Test coverage maintained:

• All original test assertions remain intact
• The fix addresses test reliability issues without changing test scope
• Cross-platform compatibility improved

Platform Compatibility

✅ Excellent improvement: This change specifically addresses macOS IPv6-only listener issues while maintaining compatibility with other platforms.

---

Recommendation: ✅ Approve - This is a well-executed fix for a specific platform compatibility issue with clear documentation and no negative side effects.

---