Skip to content

fix: use basegame validation for CustomInfo #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louis1706 merged 2 commits into from
Apr 19, 2025
Merged

fix: use basegame validation for CustomInfo #452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e6d8f6
Validate using basegame
obvEve Feb 28, 2025
cb60499
Update EXILED/Exiled.API/Features/Player.cs
louis1706 Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 3 additions & 30 deletions EXILED/Exiled.API/Features/Player.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,37 +348,10 @@ public string CustomInfo
get => ReferenceHub.nicknameSync.Network_customPlayerInfoString;
set
{
// NW Client check.
if (value.Contains<char>('<'))
if (NicknameSync.ValidateCustomInfo(value, out string rejectionText))
{
foreach (string token in value.Split('<'))
{
if (token.StartsWith("/", StringComparison.Ordinal) ||
token.StartsWith("b>", StringComparison.Ordinal) ||
token.StartsWith("i>", StringComparison.Ordinal) ||
token.StartsWith("size=", StringComparison.Ordinal) ||
token.Length is 0)
continue;

if (token.StartsWith("color=", StringComparison.Ordinal))
{
if (token.Length < 14 || token[13] != '>')
Log.Error($"Custom info of player {Nickname} has been REJECTED. \nreason: (Bad text reject) \ntoken: {token} \nInfo: {value}");
else if (!Misc.AllowedColors.ContainsValue(token.Substring(6, 7)))
Log.Error($"Custom info of player {Nickname} has been REJECTED. \nreason: (Bad color reject) \ntoken: {token} \nInfo: {value}");
}
else if (token.StartsWith("#", StringComparison.Ordinal))
{
if (token.Length < 8 || token[7] != '>')
Log.Error($"Custom info of player {Nickname} has been REJECTED. \nreason: (Bad text reject) \ntoken: {token} \nInfo: {value}");
else if (!Misc.AllowedColors.ContainsValue(token.Substring(0, 7)))
Log.Error($"Custom info of player {Nickname} has been REJECTED. \nreason: (Bad color reject) \ntoken: {token} \nInfo: {value}");
}
else
{
Log.Error($"Custom info of player {Nickname} has been REJECTED. \nreason: (Bad color reject) \ntoken: {token} \nInfo: {value}");
}
}
Log.Error($"Could not set CustomInfo for {Nickname}. Reason: {rejectionText}");
return;
}

InfoArea = string.IsNullOrEmpty(value) ? InfoArea & ~PlayerInfoArea.CustomInfo : InfoArea |= PlayerInfoArea.CustomInfo;
Expand Down