feat: Add extensions available in DoorType#496
Closed
GoldenPig1205 wants to merge 7 commits intoExMod-Team:devfrom
GoldenPig1205:pr3
Closed
feat: Add extensions available in DoorType#496GoldenPig1205 wants to merge 7 commits intoExMod-Team:devfrom GoldenPig1205:pr3
GoldenPig1205 wants to merge 7 commits intoExMod-Team:devfrom
GoldenPig1205:pr3
Conversation
louis1706
requested changes
Apr 20, 2025
louis1706
left a comment
There was a problem hiding this comment.
Please do not use .ToString().Contains() that do not fit our way to handling it
louis1706
requested changes
Apr 21, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Added extensions available in DoorType
and modified some of the behavior of functions that existed in the existing DoorType.What is the current behavior? (You can also link to an open issue here)
There were 3 extension functions (IsGate(), IsCheckpoint(), IsElevator()) and they were working fine.
What is the new behavior? (if this is a feature change)
Added 8 extension functions (IsHID(), IsScp(), IsEscape(), IsLcz(), IsHcz(), IsEz(), IsSurface(), IsUnknown()).
All extension functions belonging to DoorType now derive bool values from String values.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
❌
Other information:
This PR does not change the way existing features work. It also does not change the result.
Even if the DoorType enum is added, you don't need to manually update the extension functions of DoorType.This PR is possible because DoorType names follow a set of rules.Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other