Skip to content

refactor: AttackingEventArgs -> CardiacAttackingEventArgs(Scp049) & CapturingEventArgs(Scp106)#497

Closed
GoldenPig1205 wants to merge 9 commits intoExMod-Team:devfrom
GoldenPig1205:pr4
Closed

refactor: AttackingEventArgs -> CardiacAttackingEventArgs(Scp049) & CapturingEventArgs(Scp106)#497
GoldenPig1205 wants to merge 9 commits intoExMod-Team:devfrom
GoldenPig1205:pr4

Conversation

@GoldenPig1205
Copy link

@GoldenPig1205 GoldenPig1205 commented Apr 20, 2025

Description

Describe the changes
Scp106 class and the Scp049 class contain an AttackingEventArgs event handler with the same name.
I have differentiated them.

What is the current behavior? (You can also link to an open issue here)
When using the Scp106 and Scp049 event handlers in the same file, the event handler class declaration could not be optimized using the using directive.

What is the new behavior? (if this is a feature change)
Scp049 -> AttackingEventArgs -> CardiacAttackingEventArgs
Scp106 -> AttackingEventArgs -> CapturingEventArgs
Changed the attack name based on the official wiki -> https://en.scpslgame.com/index.php?title=SCPs

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
yes, they must change AttackingEventArgs each scp event handler class

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706 louis1706 changed the base branch from master to dev April 21, 2025 15:46
@GoldenPig1205 GoldenPig1205 changed the title refactor: Differentiating AttackingEventArgs refactor: AttackingEventArgs -> CardiacAttackingEventArgs & CapturingEventArgs Apr 25, 2025
@GoldenPig1205 GoldenPig1205 changed the title refactor: AttackingEventArgs -> CardiacAttackingEventArgs & CapturingEventArgs refactor: AttackingEventArgs -> CardiacAttackingEventArgs(Scp049) & CapturingEventArgs(Scp106) Apr 25, 2025
@GoldenPig1205 GoldenPig1205 closed this by deleting the head repository May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants