refactor: AttackingEventArgs -> CardiacAttackingEventArgs(Scp049) & CapturingEventArgs(Scp106)#497
Closed
GoldenPig1205 wants to merge 9 commits intoExMod-Team:devfrom
GoldenPig1205:pr4
Closed
refactor: AttackingEventArgs -> CardiacAttackingEventArgs(Scp049) & CapturingEventArgs(Scp106)#497GoldenPig1205 wants to merge 9 commits intoExMod-Team:devfrom GoldenPig1205:pr4
GoldenPig1205 wants to merge 9 commits intoExMod-Team:devfrom
GoldenPig1205:pr4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Scp106 class and the Scp049 class contain an AttackingEventArgs event handler with the same name.
I have differentiated them.
What is the current behavior? (You can also link to an open issue here)
When using the Scp106 and Scp049 event handlers in the same file, the event handler class declaration could not be optimized using the using directive.
What is the new behavior? (if this is a feature change)
Scp049 -> AttackingEventArgs -> CardiacAttackingEventArgs
Scp106 -> AttackingEventArgs -> CapturingEventArgs
Changed the attack name based on the official wiki -> https://en.scpslgame.com/index.php?title=SCPs
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
yes, they must change AttackingEventArgs each scp event handler class
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other